yesamer commented on code in PR #2253:
URL:
https://github.com/apache/incubator-kie-kogito-apps/pull/2253#discussion_r2282154654
##########
jitexecutor/jitexecutor-common/src/main/java/org/kie/kogito/jitexecutor/common/requests/MultipleResourcesPayload.java:
##########
@@ -24,6 +24,7 @@ public class MultipleResourcesPayload {
private String mainURI;
private List<ResourceWithURI> resources;
+ private boolean isStrictMode;
Review Comment:
@gitgabrio @AthiraHari77 Most likely you already discussed where to place
this new `isStrictMode` field. At first glance, it seems more DMN-scoped so, I
would add it in the `JITDMNPayload` instead, but maybe there's a good reason
you decided to put it here. Thoughts?
##########
jitexecutor/jitexecutor-common/src/main/java/org/kie/kogito/jitexecutor/common/requests/MultipleResourcesPayload.java:
##########
@@ -33,6 +34,12 @@ public MultipleResourcesPayload(String mainURI,
List<ResourceWithURI> resources)
this.resources = resources;
}
+ public MultipleResourcesPayload(String mainURI, List<ResourceWithURI>
resources, boolean isStrictMode) {
Review Comment:
@AthiraHari77 Considering there are multiple constructors, I guess we should
define a default value for `isStrictMode`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
