ljmotta commented on code in PR #3246:
URL:
https://github.com/apache/incubator-kie-tools/pull/3246#discussion_r2291150820
##########
packages/unitables-dmn/src/i18n/locales/en.ts:
##########
@@ -20,10 +20,12 @@
import { DmnUnitablesI18n } from "..";
import { en as en_common } from "@kie-tools/i18n-common-dictionary";
import { en as en_boxed_expression } from
"@kie-tools/boxed-expression-component/dist/i18n/locales/en";
+import { en as en_unitables } from "@kie-tools/unitables/dist/i18n/locales/en";
export const en: DmnUnitablesI18n = {
...en_common,
...en_boxed_expression,
+ ...en_unitables,
Review Comment:
We can't be sure the Boxed Expression dictionary will not have any word that
we have on Unitables. I believe it's better to spread the dictionaries into
another property, to avoid word clash.
`boxedExpression:`
`unitables:`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
