fjtirado commented on code in PR #4033: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/4033#discussion_r2292045734
########## kogito-serverless-workflow/kogito-serverless-workflow-builder/src/test/java/org/kie/kogito/serverless/workflow/SwitchStateServerlessWorkflowParsingTest.java: ########## @@ -19,24 +19,9 @@ package org.kie.kogito.serverless.workflow; import org.jbpm.ruleflow.core.RuleFlowProcess; -import org.jbpm.workflow.core.node.ActionNode; Review Comment: I forgot to mention that I deleted the workflow structure checks (but not the validation check within those tests), because: 1) They are not testing any functionality, just checking that the process has certain nodes of certain types in a hardcoded position. 2) Every time we change the workflow definition to fix something, these test will fail (because the structure has changed) and it is really painful to make them work again Since, in my opinion, testing that the structure does not change is like testing that the code does not change (its going and should change) I decided to remove them for good. The functionality that was failing is covered [here](https://github.com/apache/incubator-kie-kogito-runtimes/pull/4033/files#diff-c3dee21028fdb10120c6cb0274aade37a94ecfdc294c2b4864ce02224938087cR121-R136) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
