This is an automated email from the ASF dual-hosted git repository.
tiagobento pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-kie-tools.git
The following commit(s) were added to refs/heads/main by this push:
new b1a7091d138 kie-issues#3236: Review i18n in editor package (#3237)
b1a7091d138 is described below
commit b1a7091d13806766fdd588dbf4b79dc224b67fc2
Author: Kusuma04-dev <[email protected]>
AuthorDate: Tue Aug 26 04:25:54 2025 +0530
kie-issues#3236: Review i18n in editor package (#3237)
Co-authored-by: Kusuma <[email protected]>
---
packages/editor/src/embedded/embedded/EmbeddedEditor.tsx | 16 ++++++++++------
packages/editor/src/envelope/i18n/EditorEnvelopeI18n.ts | 2 ++
packages/editor/src/envelope/i18n/locales/de.ts | 3 ++-
packages/editor/src/envelope/i18n/locales/en.ts | 2 ++
packages/online-editor/src/editor/EditorPage.tsx | 2 +-
packages/online-editor/src/i18n/locales/de.ts | 2 +-
6 files changed, 18 insertions(+), 9 deletions(-)
diff --git a/packages/editor/src/embedded/embedded/EmbeddedEditor.tsx
b/packages/editor/src/embedded/embedded/EmbeddedEditor.tsx
index 107218ce624..a06a239fc87 100644
--- a/packages/editor/src/embedded/embedded/EmbeddedEditor.tsx
+++ b/packages/editor/src/embedded/embedded/EmbeddedEditor.tsx
@@ -34,6 +34,12 @@ import { EmbeddedEditorChannelApiImpl } from
"./EmbeddedEditorChannelApiImpl";
import { EnvelopeServer } from "@kie-tools-core/envelope-bus/dist/channel";
import { useConnectedEnvelopeServer } from
"@kie-tools-core/envelope-bus/dist/hooks";
import { getEditorIframeProps } from "../../channel/editorIframeProps";
+import {
+ editorEnvelopeI18nDefaults,
+ editorEnvelopeI18nDictionaries,
+ useEditorEnvelopeI18nContext,
+} from "../../envelope/i18n";
+import { I18n } from "@kie-tools-core/i18n/dist/core";
type Omit<T, K extends keyof T> = Pick<T, Exclude<keyof T, K>>;
@@ -81,11 +87,9 @@ const RefForwardingEmbeddedEditor:
React.ForwardRefRenderFunction<EmbeddedEditor
props: Props,
forwardedRef
) => {
+ const i18n = new I18n(editorEnvelopeI18nDefaults,
editorEnvelopeI18nDictionaries, props.locale).getCurrent();
const iframeRef = useRef<HTMLIFrameElement>(null);
- const stateControl = useMemo(
- () => props.stateControl ?? new StateControl(),
- [props.file.getFileContents, props.stateControl]
- );
+ const stateControl = useMemo(() => props.stateControl ?? new StateControl(),
[props.stateControl]);
const [isReady, setReady] = useState(false);
const envelopeMapping = useMemo(
() =>
@@ -200,7 +204,7 @@ const RefForwardingEmbeddedEditor:
React.ForwardRefRenderFunction<EmbeddedEditor
<>
{!envelopeMapping && (
<>
- <span>{`No Editor available for '${props.file.fileExtension}'
extension`}</span>
+ <span>{i18n.editorNotAvailable(props.file.fileExtension)}</span>
</>
)}
{envelopeMapping && (
@@ -208,7 +212,7 @@ const RefForwardingEmbeddedEditor:
React.ForwardRefRenderFunction<EmbeddedEditor
ref={iframeRef}
id={"kogito-iframe"}
data-testid={"kogito-iframe"}
- title="Kogito editor"
+ title={i18n.kogitoEditor}
style={containerStyles}
data-envelope-channel={props.channelType}
{...getEditorIframeProps(envelopeMapping)}
diff --git a/packages/editor/src/envelope/i18n/EditorEnvelopeI18n.ts
b/packages/editor/src/envelope/i18n/EditorEnvelopeI18n.ts
index d02b96ec207..5cff816f759 100644
--- a/packages/editor/src/envelope/i18n/EditorEnvelopeI18n.ts
+++ b/packages/editor/src/envelope/i18n/EditorEnvelopeI18n.ts
@@ -35,6 +35,8 @@ export interface EditorEnvelopeDictionary extends
ReferenceDictionary {
loadingScreen: {
loading: string;
};
+ editorNotAvailable: (extension: string) => string;
+ kogitoEditor: string;
}
export interface EditorEnvelopeI18n extends EditorEnvelopeDictionary {}
diff --git a/packages/editor/src/envelope/i18n/locales/de.ts
b/packages/editor/src/envelope/i18n/locales/de.ts
index 42967bf5f54..67301818501 100644
--- a/packages/editor/src/envelope/i18n/locales/de.ts
+++ b/packages/editor/src/envelope/i18n/locales/de.ts
@@ -17,9 +17,10 @@
* under the License.
*/
+import { TranslatedDictionary } from "@kie-tools-core/i18n/dist/core";
import { EditorEnvelopeI18n } from "../EditorEnvelopeI18n";
-export const de: EditorEnvelopeI18n = {
+export const de: TranslatedDictionary<EditorEnvelopeI18n> = {
keyBindingsHelpOverlay: {
title: "Tastenkombinationen",
categories: {
diff --git a/packages/editor/src/envelope/i18n/locales/en.ts
b/packages/editor/src/envelope/i18n/locales/en.ts
index b1734aa1b79..f322516bbd9 100644
--- a/packages/editor/src/envelope/i18n/locales/en.ts
+++ b/packages/editor/src/envelope/i18n/locales/en.ts
@@ -35,4 +35,6 @@ export const en: EditorEnvelopeI18n = {
loadingScreen: {
loading: "Loading...",
},
+ editorNotAvailable: (extension: string): string => `No Editor available for
'${extension}' extension`,
+ kogitoEditor: "Kogito editor",
};
diff --git a/packages/online-editor/src/editor/EditorPage.tsx
b/packages/online-editor/src/editor/EditorPage.tsx
index 6544f6798a1..25345cd9af8 100644
--- a/packages/online-editor/src/editor/EditorPage.tsx
+++ b/packages/online-editor/src/editor/EditorPage.tsx
@@ -63,7 +63,7 @@ import {
EmptyStateIcon,
EmptyStateHeader,
} from "@patternfly/react-core/dist/js/components/EmptyState";
-import { I18nWrapped } from "@kie-tools-core/i18n/dist/react-components";
+import { I18nDictionariesProvider, I18nWrapped } from
"@kie-tools-core/i18n/dist/react-components";
import { ExclamationTriangleIcon } from
"@patternfly/react-icons/dist/js/icons/exclamation-triangle-icon";
import { useEnv } from "../env/hooks/EnvContext";
import { useSettings } from "../settings/SettingsContext";
diff --git a/packages/online-editor/src/i18n/locales/de.ts
b/packages/online-editor/src/i18n/locales/de.ts
index 42b3a544985..7efdddfa635 100644
--- a/packages/online-editor/src/i18n/locales/de.ts
+++ b/packages/online-editor/src/i18n/locales/de.ts
@@ -20,7 +20,7 @@
import { OnlineI18n } from "..";
import { de as de_common } from "@kie-tools/i18n-common-dictionary";
import { de as de_unitables } from "@kie-tools/unitables/dist/i18n/locales/de";
-import { wrapped } from "@kie-tools-core/i18n/dist/core";
+import { TranslatedDictionary, wrapped } from "@kie-tools-core/i18n/dist/core";
export const de: OnlineI18n = {
...de_common,
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
