handreyrc commented on code in PR #3252: URL: https://github.com/apache/incubator-kie-tools/pull/3252#discussion_r2342852593
########## packages/swf-editor/src/marshallers/swfMarshaller.ts: ########## Review Comment: @tiagobento The 0.8 SWF SDK is class based so the same interface approach wouldn't work without creating something in the middle generate / convert it to interfaces. I understand that DMN editor takes a model instance and that validation / error handling is done in the envelope. It is something that can be considered when we will create the envelope. On the other hand, we may need to use the diagram editor without the envelope and maybe we would keep it as is. For now we need it to make it work without the envelope. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
