Copilot commented on code in PR #6446:
URL:
https://github.com/apache/incubator-kie-drools/pull/6446#discussion_r2329789140
##########
kie-dmn/kie-dmn-core/src/test/java/org/kie/dmn/core/util/DMNRuntimeUtil.java:
##########
@@ -96,7 +97,7 @@ public static List<DMNMessage>
createExpectingDMNMessages(final String resourceN
.filter(DMNMessage.class::isInstance)
.map(DMNMessage.class::cast)
.collect(Collectors.toList());
- assertThat(dmnMessages).isNotEmpty();;
+ assertThat(dmnMessages).isNotEmpty();
Review Comment:
Fixed the double semicolon at the end of the line, which was a syntax error.
##########
kie-dmn/kie-dmn-core/src/test/java/org/kie/dmn/core/DMNInputRuntimeTest.java:
##########
@@ -759,13 +759,13 @@ void errorHandlingWithLenientMode(boolean
useExecModelCompiler) {
}
@ParameterizedTest
- @MethodSource("params")
- void errorHandlingWithStrictModeEvaluateAll(boolean useExecModelCompiler) {
- init(useExecModelCompiler);
+ @MethodSource("strictMode")
+ void errorHandlingWithWithoutStrictModeEvaluateAll(boolean strictMode) {
+ init(false, strictMode);
String nameSpace =
"https://kie.org/dmn/_79591DB5-1EE1-4CBD-AA5D-2E3EDF31155E";;
final DMNRuntime runtime =
DMNRuntimeUtil.createRuntime("invalid_models/DMNv1_6/DMN-MultipleInvalidElements"
+
".dmn", this.getClass());
- ((DMNRuntimeImpl)runtime).setOption(new
RuntimeModeOption(RuntimeModeOption.MODE.STRICT));
+ //((DMNRuntimeImpl)runtime).setOption(new
RuntimeModeOption(RuntimeModeOption.MODE.STRICT));
Review Comment:
Remove this commented-out code as the strict mode is now handled
automatically via system properties in the test infrastructure.
```suggestion
```
##########
kie-dmn/kie-dmn-core/src/test/java/org/kie/dmn/core/DMNInputRuntimeTest.java:
##########
@@ -774,13 +774,25 @@ void errorHandlingWithStrictModeEvaluateAll(boolean
useExecModelCompiler) {
final DMNContext dmnContext = DMNFactory.newContext();
dmnContext.set("id", "_7273EA2E-2CC3-4012-8F87-39E310C8DF3C");
dmnContext.set("Conditional Input", 107);
Review Comment:
[nitpick] The change from integer 8888 to string \"8888\" appears to be
intentional for testing type validation, but this change should be documented
or explained in the test method name or comments to clarify why this input type
was modified.
```suggestion
dmnContext.set("Conditional Input", 107);
// Intentionally set "New Input Data" to a string instead of an
integer to test type validation and error handling.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
