jstastny-cz opened a new pull request, #4062: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/4062
Fixing PredictionCodegenFactory class which was using File.separator matches against an instance of PortablePath. PortablePath though contains forward slashes `/` even on Windows, this such File.separator match fails there and results in error during code generation. (The only non-test fix in this PR). Fixing several problems in tests causing failures in Windows: * resource path has always forward slash `/` no need for `File.separator` in there. Replacing such File.separator references with plain `/` string/char. * URL#getPath method returns resource path - not a valid path on Windows. Switching to Paths#get method signature that accepts URI parameter instead. * flaky DeadlineHelperTest has perhaps a too strict check on expiration time, using `isAfter` assertion, which IMHO is susceptible to cases when the test is too fast (assumption). Adding a few millis to stabilize. * replacing string comparison on paths with Path instances comparisons. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
