Rikkola commented on code in PR #6460:
URL:
https://github.com/apache/incubator-kie-drools/pull/6460#discussion_r2361913249
##########
drools-base/src/main/java/org/drools/base/base/extractors/BaseObjectClassFieldReader.java:
##########
@@ -151,6 +109,10 @@ public String getNativeReadMethodName() {
Class<?> type = getExtractToClass();
if (!type.isPrimitive()) {
return "getValue";
+ } else if (type == int.class || type == long.class || type ==
short.class || type == byte.class || type == char.class) {
+ return "getWholeNumberValue";
+ } else if (type == float.class || type == double.class) {
+ return "getDecimalValue";
}
return "get" + type.getName().substring(0, 1).toUpperCase() +
type.getName().substring(1) + "Value";
Review Comment:
In two locations we do "get" + type + "Value" to get the method name. This
is currently only the fall back for Booleans if I am not wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
