mariofusco commented on code in PR #6461:
URL:
https://github.com/apache/incubator-kie-drools/pull/6461#discussion_r2362453428
##########
drools-core/src/main/java/org/drools/core/phreak/PhreakBranchNode.java:
##########
@@ -166,11 +166,8 @@ public void doLeftUpdates(ConditionalBranchNode branchNode,
if (branchTuples.mainLeftTuple != null) {
normalizeStagedTuples( stagedLeftTuples,
branchTuples.mainLeftTuple );
- if (breaking &&
!NodeTypeEnums.isTerminalNode(branchTuples.mainLeftTuple.getSink())) {
- // child exist, new one does not, so delete
- trgLeftTuples.addDelete(branchTuples.mainLeftTuple);
- } else {
- // child exist, new one does, so update
+ if (!breaking) {
+ // default consequence will also be executed
trgLeftTuples.addUpdate(branchTuples.mainLeftTuple);
}
Review Comment:
I agree, I believe that A) is the right thing to do here, great job.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
