LightGuard commented on code in PR #1284:
URL:
https://github.com/apache/incubator-kie-kogito-pipelines/pull/1284#discussion_r2430386805
##########
tools/zip-sources-files/build.sh:
##########
@@ -23,9 +23,6 @@ check_requirements() {
exit 1
fi
done
-
- # Check Python packages
- pip3 install cekit==4.11.0 docker==7.0.0 docker-squash==1.2.0
ruamel.yaml==0.18.5
Review Comment:
Why are we removing the check?
##########
tools/zip-sources-files/build.sh:
##########
@@ -62,24 +59,6 @@ build_components() {
mvn clean install -DskipTests -Dfull -Donly.reproducible=true
-Pjitexecutor-native
cd ..
- # Build Kogito Images
- cd incubator-kie-kogito-images || exit 1
- cekit --descriptor kogito-base-builder-image.yaml build docker --platform
linux/amd64
-
- local images=(
- "kogito-data-index-ephemeral"
- "kogito-data-index-postgresql"
- "kogito-jit-runner"
- "kogito-jobs-service-allinone"
- "kogito-jobs-service-ephemeral"
- "kogito-jobs-service-postgresql"
- )
-
- for image in "${images[@]}"; do
- make build-image KOGITO_APPS_TARGET_BRANCH=main ignore_test=true
image_name="$image"
- done
- cd ..
-
Review Comment:
Are we handling these in a different place?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
