LightGuard commented on code in PR #3293:
URL:
https://github.com/apache/incubator-kie-tools/pull/3293#discussion_r2427296041
##########
.ci/jenkins/Jenkinsfile.release-candidate:
##########
@@ -30,11 +30,17 @@ pipeline {
timeout(time: 180, unit: 'MINUTES')
}
+ environment {
+ MAVEN_ARGS = "-B -s ${WORKSPACE}/kie-settings.xml
-Dmaven.repo.local=${WORKSPACE}/.maven"
+ }
+
parameters {
- string(name: 'BRANCH_NAME', description: 'Set the Git branch to
checkout (0.0.x)', trim: true)
- string(name: 'RELEASE_VERSION', description: 'Release version', trim:
true)
- string(name: 'TAG_NAME', description: 'Tag name to be created', trim:
true)
- string(description: 'Runners', name: 'RUNNERS', defaultValue:
'{"chrome_extensions":"true","cors_proxy_image":"true","dashbuilder_viewer_image":"true","dev_deployment_base_image":"true","kie_sandbox_accelerator_quarkus":"true","dev_deployment_dmn_form_webapp_image":"true","dev_deployment_kogito_quakus_blank_app_image":"true","dev_deployment_upload_service":"true","extended_services":"true","jbpm_quarkus_devui":"true","kie_sandbox_extended_services_image":"true","kie_sandbox_helm_chart":"true","kie_sandbox_image":"true","kn_plugin_workflow":"true","kogito_management_console":"true","kogito_swf_builder":"true","kogito_swf_devmode":"true","kogito_serverless_operator":"true","npm_packages":"true","online_editor":"true","runtime_tools_consoles_helm_chart":"true","serverless_logic_web_tools":"true","serverless_logic_web_tools_base_builder_image":"true","serverless_logic_web_tools_swf_builder_image":"true","serverless_logic_web_tools_swf_dev_mode_image":"true","standalone_editors_c
dn":"true","sonataflow_quarkus_devui":"true","vscode_extensions_dev":"true","vscode_extensions_prod":"true"}')
+ string(name: 'BRANCH_NAME', description: 'Set the Git branch to
checkout (0.0.x)', trim: true, defaultValue: '10.1.x')
+ string(name: 'RELEASE_VERSION', description: 'Release version', trim:
true, defaultValue: '10.1.0')
+ string(name: 'RELEASE_CANDIDATE_VERSION', description: 'Release
candidate version', trim: true, defaultValue: '10.1.0-rc1')
Review Comment:
Does a build need to define each of these, or only one? I would think that
you'd need both RELEASE_VERSION and the CANDIDATE_VERSION would get appended if
it was given. Without any additional information in the descriptions this is
confusing.
##########
.ci/jenkins/Jenkinsfile.release-candidate:
##########
@@ -30,11 +30,17 @@ pipeline {
timeout(time: 180, unit: 'MINUTES')
}
+ environment {
+ MAVEN_ARGS = "-B -s ${WORKSPACE}/kie-settings.xml
-Dmaven.repo.local=${WORKSPACE}/.maven"
+ }
+
parameters {
- string(name: 'BRANCH_NAME', description: 'Set the Git branch to
checkout (0.0.x)', trim: true)
- string(name: 'RELEASE_VERSION', description: 'Release version', trim:
true)
- string(name: 'TAG_NAME', description: 'Tag name to be created', trim:
true)
- string(description: 'Runners', name: 'RUNNERS', defaultValue:
'{"chrome_extensions":"true","cors_proxy_image":"true","dashbuilder_viewer_image":"true","dev_deployment_base_image":"true","kie_sandbox_accelerator_quarkus":"true","dev_deployment_dmn_form_webapp_image":"true","dev_deployment_kogito_quakus_blank_app_image":"true","dev_deployment_upload_service":"true","extended_services":"true","jbpm_quarkus_devui":"true","kie_sandbox_extended_services_image":"true","kie_sandbox_helm_chart":"true","kie_sandbox_image":"true","kn_plugin_workflow":"true","kogito_management_console":"true","kogito_swf_builder":"true","kogito_swf_devmode":"true","kogito_serverless_operator":"true","npm_packages":"true","online_editor":"true","runtime_tools_consoles_helm_chart":"true","serverless_logic_web_tools":"true","serverless_logic_web_tools_base_builder_image":"true","serverless_logic_web_tools_swf_builder_image":"true","serverless_logic_web_tools_swf_dev_mode_image":"true","standalone_editors_c
dn":"true","sonataflow_quarkus_devui":"true","vscode_extensions_dev":"true","vscode_extensions_prod":"true"}')
+ string(name: 'BRANCH_NAME', description: 'Set the Git branch to
checkout (0.0.x)', trim: true, defaultValue: '10.1.x')
+ string(name: 'RELEASE_VERSION', description: 'Release version', trim:
true, defaultValue: '10.1.0')
+ string(name: 'RELEASE_CANDIDATE_VERSION', description: 'Release
candidate version', trim: true, defaultValue: '10.1.0-rc1')
+ string(name: 'TAG_NAME', description: 'Tag name to be created', trim:
true, defaultValue: '10.1.0-rc1')
Review Comment:
Why would the tag name be anything different than RELEASE_VERSION +
CANDIDATE_VERSION?
##########
.ci/jenkins/release-jobs/Jenkinsfile.dev-deployment-quarkus-blank-app-image:
##########
@@ -23,14 +23,15 @@ pipeline {
}
options {
- timeout(time: 60, unit: 'MINUTES')
+ timeout(time: 180, unit: 'MINUTES')
Review Comment:
It can take 3 hours for this one to run?
##########
.ci/jenkins/release-jobs/Jenkinsfile.serverless-logic-web-tools-swf-builder-image:
##########
@@ -31,6 +31,7 @@ pipeline {
string(description: 'Release Version', name: 'RELEASE_VERSION',
defaultValue: '0.0.0')
string(description: 'Base Ref', name: 'BASE_REF')
string(description: 'Release Candidate Version', name:
'RELEASE_CANDIDATE_VERSION', defaultValue: '')
+ string(name: 'PIPELINE_PATH', description: 'Path to run the pipeline')
Review Comment:
A number of these jobs have this param in them, is it supposed to point to
the URL of the job to run? The Jenkinsfile?
##########
.ci/jenkins/Jenkinsfile.release-candidate:
##########
@@ -30,11 +30,17 @@ pipeline {
timeout(time: 180, unit: 'MINUTES')
}
+ environment {
+ MAVEN_ARGS = "-B -s ${WORKSPACE}/kie-settings.xml
-Dmaven.repo.local=${WORKSPACE}/.maven"
Review Comment:
Is `kie-settings.xml` within the docker image, or should it be added to this
PR as well?
##########
.ci/jenkins/Jenkinsfile.release-candidate:
##########
@@ -164,19 +170,21 @@ pipeline {
script {
githubUtils.createTag("${params.TAG_NAME}")
githubUtils.pushObject('origin', "${params.TAG_NAME}",
"${pipelineVars.asfGithubPushCredentialsId}")
+ sleep(time: 1, unit: 'MINUTES') // Wait for the tag to
be created
Review Comment:
Might a `waitUntil` step that checks for the existence of the remote tag
work better here than sleep?
##########
.ci/jenkins/Jenkinsfile.release-publish:
##########
@@ -31,7 +31,7 @@ pipeline {
parameters {
string(description: 'Release Version', name: 'RELEASE_VERSION',
defaultValue: '0.0.0')
- string(description: 'Runners', name: 'RUNNERS', defaultValue:
'{"chrome_extensions":"true","cors_proxy_image":"true","dashbuilder_viewer_image":"true","dev_deployment_base_image":"true","kie_sandbox_accelerator_quarkus":"true","dev_deployment_dmn_form_webapp_image":"true","dev_deployment_kogito_quakus_blank_app_image":"true","dev_deployment_upload_service":"true","extended_services":"true","jbpm_quarkus_devui":"true","kie_sandbox_extended_services_image":"true","kie_sandbox_helm_chart":"true","kie_sandbox_image":"true","kn_plugin_workflow":"true","kogito_management_console":"true","kogito_swf_builder":"true","kogito_swf_devmode":"true","kogito_serverless_operator":"true","npm_packages":"true","online_editor":"true","runtime_tools_consoles_helm_chart":"true","serverless_logic_web_tools":"true","serverless_logic_web_tools_base_builder_image":"true","serverless_logic_web_tools_swf_builder_image":"true","serverless_logic_web_tools_swf_dev_mode_image":"true","standalone_editors_c
dn":"true","sonataflow_quarkus_devui":"true","vscode_extensions_dev":"true","vscode_extensions_prod":"true"}')
+ string(description: 'Runners', name: 'RUNNERS', defaultValue:
'{"chrome_extensions":"true","cors_proxy_image":"true","dashbuilder_viewer_image":"true","dev_deployment_base_image":"true","kie_sandbox_accelerator_quarkus":"true","dev_deployment_dmn_form_webapp_image":"true","dev_deployment_quakus_blank_app_image":"true","dev_deployment_upload_service":"true","extended_services":"true","jbpm_quarkus_devui":"true","kie_sandbox_extended_services_image":"true","kie_sandbox_helm_chart":"true","kie_sandbox_image":"true","kn_plugin_workflow":"true","kogito_management_console":"true","kogito_swf_builder":"true","kogito_swf_devmode":"true","kogito_serverless_operator":"true","npm_packages":"true","online_editor":"true","runtime_tools_consoles_helm_chart":"true","serverless_logic_web_tools":"true","serverless_logic_web_tools_base_builder_image":"true","serverless_logic_web_tools_swf_builder_image":"true","serverless_logic_web_tools_swf_dev_mode_image":"true","standalone_editors_cdn":"tr
ue","sonataflow_quarkus_devui":"true","vscode_extensions_dev":"true","vscode_extensions_prod":"true"}')
Review Comment:
I think this needs to happen and in multiple places. We have a number of
"dev_deployment_quakus" instances.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
