fjtirado commented on code in PR #4021: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/4021#discussion_r2428528061
########## quarkus/addons/jwt-parser/runtime/src/main/java/org/kie/kogito/addons/jwt/JwtTokenParser.java: ########## @@ -0,0 +1,126 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.kie.kogito.addons.jwt; + +import java.nio.charset.StandardCharsets; +import java.util.Base64; + +import com.fasterxml.jackson.databind.JsonNode; +import com.fasterxml.jackson.databind.ObjectMapper; +import com.fasterxml.jackson.databind.node.ObjectNode; + +import jakarta.enterprise.context.ApplicationScoped; + +/** + * JWT Token Parser utility for extracting claims from JWT tokens + * Used by SonataFlow workflows to parse JWT tokens and access claims + */ +@ApplicationScoped +public class JwtTokenParser { + + private static final ObjectMapper OBJECT_MAPPER = new ObjectMapper(); + + /** + * Parses a JWT token and returns the payload as a JsonNode + * + * @param token The JWT token string (can include "Bearer " prefix) + * @return JsonNode containing the JWT payload/claims + * @throws RuntimeException if token parsing fails + */ + public JsonNode parseToken(String token) { + if (token == null || token.trim().isEmpty()) { + throw new IllegalArgumentException("JWT token cannot be null or empty"); + } + + // Remove "Bearer " prefix if present + String cleanToken = token.startsWith("Bearer ") ? token.substring(7) : token; Review Comment: Picky comment, but I think is safer to do this At class level `private static final String BEARER = "Bearer ";` And here `String cleanToken = token.startsWith(BEARER) ? token.substring(BEARER.length()) : token;` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
