fantonangeli commented on PR #3327: URL: https://github.com/apache/incubator-kie-tools/pull/3327#issuecomment-3457520631
> Do we need to include the protocol in the `origin`? I mean, I see our usage varies from `http` and `https`, depending on the package. Wondering if it would be possible to default to `localhost` without having to specify the protocol. @tiagobento Yes the same issue is for the http port, and I added `http://localhost` without the port just to have a default (null and `*` are not accepted). Maybe for the protocol I can achieve this programmatically, but the problem remains for the port. But actually thinking about it again maybe I can completely set the origin programmatically (ONLY if it's localhost and it's a dev environment). The advantage would be that I don't have to set the `CORS_DOMAIN` in the all the `package.json` like in this PR. Only note is that I'm not totally sure CodeQL accept this "logic". wdyt? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
