mariofusco commented on code in PR #6508:
URL:
https://github.com/apache/incubator-kie-drools/pull/6508#discussion_r2478242616
##########
drools-core/src/main/java/org/drools/core/phreak/EagerPhreakBuilder.java:
##########
@@ -1121,8 +1121,9 @@ private static TupleImpl
insertPeerLeftTuple(InternalWorkingMemory wm,
memory.getSegmentMemory().getStagedLeftTuples().addInsert(peer);
} else {
// If parent is Lian, then this must be called, so that any
linking or unlinking can be done.
- LeftInputAdapterNode.doInsertSegmentMemoryWithFlush(wm, true,
liaMem, memory.getSegmentMemory(), peer, node
- .getLeftTupleSource().isStreamMode());
+ List<PathMemory> pathsToFlush =
LeftInputAdapterNode.doInsertSegmentMemory(wm, true, liaMem,
memory.getSegmentMemory(), peer, node
+ .getLeftTupleSource().isStreamMode() );
+ wm.getRuleNetworkEvaluator().forceFlushPaths(pathsToFlush);
Review Comment:
Why is this force flush necessary now? Did it do this also before in a
different way?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
