pefernan commented on code in PR #4105: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/4105#discussion_r2498021363
########## jbpm/jbpm-usertask/src/main/java/org/kie/kogito/usertask/impl/lifecycle/DefaultUserTaskLifeCycles.java: ########## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.kie.kogito.usertask.impl.lifecycle; + +import java.util.HashMap; +import java.util.Map; + +import org.kie.kogito.usertask.lifecycle.UserTaskLifeCycle; +import org.kie.kogito.usertask.lifecycle.UserTaskLifeCycleException; +import org.kie.kogito.usertask.lifecycle.UserTaskLifeCycles; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +public class DefaultUserTaskLifeCycles implements UserTaskLifeCycles { + + private static final Logger LOG = LoggerFactory.getLogger(DefaultUserTaskLifeCycles.class); + + private final Map<String, UserTaskLifeCycle> userTaskLifeCycleRegistry = new HashMap<>(); + private String defaultUserTaskLifeCycleId; + + public DefaultUserTaskLifeCycles() { + this.defaultUserTaskLifeCycleId = "kogito"; + registerUserTaskLifeCycles(); + LOG.info("Registered UserTaskLifeCycles {} with default lifecycle: {}", userTaskLifeCycleRegistry, this.defaultUserTaskLifeCycleId); + } + + public DefaultUserTaskLifeCycles(String defaultUserTaskLifeCycleId, Iterable<UserTaskLifeCycle> userTaskLifeCycle) { + this.defaultUserTaskLifeCycleId = defaultUserTaskLifeCycleId; + registerCustomUserTaskLifeCycleIfAny(userTaskLifeCycle); + registerUserTaskLifeCycles(); + LOG.info("Registered UserTaskLifeCycles {} with default lifecycle: {}", userTaskLifeCycleRegistry, this.defaultUserTaskLifeCycleId); + } Review Comment: This constructor is used to initialize the bean when using the platform (quarkus/springboot) DI. Both platforms use different approaches for DI (quarkus CDI vs spring). Here we use `Iterable` to abstract from the platform although we know in this case will be one. We are using this approach in other constructors that use DI to inject implementing beans. In CDI we have `Instance` (which is an `Iterable`) to lookup implementations of a type in the cdi beans manager. Spring allows us Autowire a List or a Collection of beans implementing a class. We use this approach for our convenience. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
