josedee commented on code in PR #4105:
URL: 
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4105#discussion_r2514976831


##########
quarkus/integration-tests/integration-tests-quarkus-wshumantasks/src/test/java/org/jbpm/usertask/jpa/it/WsHumanTaskLifeCycleIT.java:
##########
@@ -0,0 +1,550 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.jbpm.userTask.jpa.it;
+
+import java.util.Arrays;
+import java.util.List;
+import java.util.Map;
+import java.util.stream.Stream;
+
+import org.junit.jupiter.api.Test;
+import org.kie.kogito.testcontainers.quarkus.PostgreSqlQuarkusTestResource;
+import org.kie.kogito.usertask.model.TransitionInfo;
+
+import io.quarkus.test.common.QuarkusTestResource;
+import io.quarkus.test.junit.QuarkusIntegrationTest;
+import io.restassured.RestAssured;
+import io.restassured.http.ContentType;
+
+import static io.restassured.RestAssured.given;
+import static org.hamcrest.CoreMatchers.equalTo;
+import static org.hamcrest.CoreMatchers.hasItems;
+import static org.hamcrest.CoreMatchers.is;
+import static org.hamcrest.CoreMatchers.not;
+import static org.hamcrest.Matchers.emptyOrNullString;
+
+@QuarkusIntegrationTest
+@QuarkusTestResource(value = PostgreSqlQuarkusTestResource.class, 
restrictToAnnotatedClass = true)
+public class WsHumanTaskLifeCycleIT {
+    public static final String USER_TASKS_ENDPOINT = "/usertasks/instance";
+    public static final String USER_TASKS_INSTANCE_ENDPOINT = 
USER_TASKS_ENDPOINT + "/{taskId}";
+    public static final String USER_TASKS_INSTANCE_TRANSITION_ENDPOINT = 
USER_TASKS_INSTANCE_ENDPOINT + "/transition";
+
+    static {
+        RestAssured.enableLoggingOfRequestAndResponseIfValidationFails();
+    }
+
+    @Test
+    public void testUserTaskLifeCycle() {
+        var user = "dave";
+        var potentialUsers = new String[] { "john", "dave" };
+        var processId = "manager_multiple_users";
+        var pid = startProcessInstance(processId);
+        var taskId = getTaskId(user);
+        verifyTask(processId, pid, taskId, user, "Ready", potentialUsers);
+        claim(taskId, user);
+        start(taskId, user);
+        complete(taskId, user);
+        isProcessCompleted(processId);
+    }
+
+    @Test
+    public void testForwardTransition() {
+        var user = "dave";
+        var potentialUsers = new String[] { "john", "dave" };
+        var forwardedUsers = new String[] { "mark", "eric" };
+        var processId = "manager_multiple_users";
+        var pid = startProcessInstance(processId);
+        var taskId = getTaskId(user);
+        verifyTask(processId, pid, taskId, user, "Ready", potentialUsers);
+        potentialUsers = forward(taskId, user, potentialUsers, 
forwardedUsers).toArray(String[]::new);
+
+        user = "mark";
+        claim(taskId, user);
+        forwardedUsers = new String[] { "adam" };
+        potentialUsers = forward(taskId, user, potentialUsers, 
forwardedUsers).toArray(String[]::new);
+
+        user = "adam";
+        claim(taskId, user);
+        forwardedUsers = new String[] { "bob" };
+        potentialUsers = forward(taskId, user, potentialUsers, 
forwardedUsers).toArray(String[]::new);
+
+        user = "bob";
+        claim(taskId, user);
+        start(taskId, user);
+        complete(taskId, user);
+
+        isProcessCompleted(processId);
+    }
+
+    @Test
+    public void testDelegateTransition() {
+        var user = "dave";
+        var potentialUsers = new String[] { "john", "dave" };
+        var processId = "manager_multiple_users";
+        var pid = startProcessInstance(processId);
+        var taskId = getTaskId(user);
+        verifyTask(processId, pid, taskId, user, "Ready", potentialUsers);
+
+        var delegatedUser = "adam";
+        potentialUsers = delegate(taskId, user, potentialUsers, 
delegatedUser).toArray(String[]::new);
+
+        user = "adam";
+        delegatedUser = "john";
+        potentialUsers = delegate(taskId, user, potentialUsers, 
delegatedUser).toArray(String[]::new);
+
+        user = "john";
+        start(taskId, user);
+        delegatedUser = "mark";
+        potentialUsers = delegate(taskId, user, potentialUsers, 
delegatedUser).toArray(String[]::new);
+
+        user = "mark";
+        start(taskId, user);
+        complete(taskId, user);
+
+        isProcessCompleted(processId);
+    }
+
+    @Test
+    public void testReleaseTransition() {
+        var user = "dave";
+        var potentialUsers = new String[] { "john", "dave" };
+        var processId = "manager_multiple_users";
+        var pid = startProcessInstance(processId);
+        var taskId = getTaskId(user);
+        verifyTask(processId, pid, taskId, user, "Ready", potentialUsers);
+
+        claim(taskId, user);
+        release(taskId, user);
+
+        user = "john";
+        claim(taskId, user);
+        start(taskId, user);
+        release(taskId, user);
+
+        user = "dave";
+        claim(taskId, user);
+        start(taskId, user);
+        complete(taskId, user);
+
+        isProcessCompleted(processId);
+    }
+
+    @Test
+    public void testStopTransition() {
+        var user = "dave";
+        var potentialUsers = new String[] { "john", "dave" };
+        var processId = "manager_multiple_users";
+        var pid = startProcessInstance(processId);
+        var taskId = getTaskId(user);
+        verifyTask(processId, pid, taskId, user, "Ready", potentialUsers);
+
+        claim(taskId, user);
+        start(taskId, user);
+        stop(taskId, user);
+
+        start(taskId, user);
+        complete(taskId, user);
+
+        isProcessCompleted(processId);
+    }
+
+    @Test
+    public void testFailTransition() {
+        var user = "dave";
+        var potentialUsers = new String[] { "john", "dave" };
+        var processId = "manager_multiple_users";
+        var pid = startProcessInstance(processId);
+        var taskId = getTaskId(user);
+        verifyTask(processId, pid, taskId, user, "Ready", potentialUsers);
+
+        claim(taskId, user);
+        start(taskId, user);
+        fail(taskId, user);
+
+        isProcessCompleted(processId);
+    }
+
+    @Test
+    public void testSuspendAndResumeTransition() {
+        var user = "dave";
+        var potentialUsers = new String[] { "john", "dave" };
+        var processId = "manager_multiple_users";
+        var pid = startProcessInstance(processId);
+        var taskId = getTaskId(user);
+        verifyTask(processId, pid, taskId, user, "Ready", potentialUsers);
+
+        suspend(taskId, user);
+        resume(taskId, user, "Ready");
+
+        claim(taskId, user);
+        suspend(taskId, user);
+        resume(taskId, user, "Reserved");
+
+        start(taskId, user);
+        suspend(taskId, user);
+        resume(taskId, user, "InProgress");
+
+        complete(taskId, user);
+
+        isProcessCompleted(processId);
+    }
+
+    @Test
+    public void testSkipTransition() {
+        var user = "dave";
+        var potentialUsers = new String[] { "john", "dave" };
+        var processId = "manager_multiple_users";
+        var pid = startProcessInstance(processId);
+        var taskId = getTaskId(user);
+        verifyTask(processId, pid, taskId, user, "Ready", potentialUsers);
+
+        claim(taskId, user);
+        start(taskId, user);
+        skip(taskId, user);
+
+        isProcessCompleted(processId);
+    }
+
+    @Test
+    public void testFaultTransition() {
+        var user = "dave";
+        var potentialUsers = new String[] { "john", "dave" };
+        var processId = "manager_multiple_users";
+        var pid = startProcessInstance(processId);
+        var taskId = getTaskId(user);
+        verifyTask(processId, pid, taskId, user, "Ready", potentialUsers);
+
+        claim(taskId, user);
+        start(taskId, user);
+        fault(taskId, user);
+
+        isProcessCompleted(processId);
+    }
+
+    @Test
+    public void testExitTransition() {
+        var user = "dave";
+        var potentialUsers = new String[] { "john", "dave" };
+        var processId = "manager_multiple_users";
+        var pid = startProcessInstance(processId);
+        var taskId = getTaskId(user);
+        verifyTask(processId, pid, taskId, user, "Ready", potentialUsers);
+
+        claim(taskId, user);
+        start(taskId, user);
+        exit(taskId, user);
+
+        isProcessCompleted(processId);
+    }
+
+    @Test
+    public void testNominateTransition() {
+        var user = "carl";
+        var processId = "manager_admin";
+        var pid = startProcessInstance(processId);
+        var taskId = getTaskId("carl");
+        verifyTask(processId, pid, taskId, user, "Created", new String[] {});
+
+        var nominatedUsers = new String[] { "john", "dave" };
+        nominate(taskId, user, "Ready", nominatedUsers);
+
+        user = "john";
+        start(taskId, user);
+        complete(taskId, user);
+
+        isProcessCompleted(processId);
+    }
+
+    private void nominate(String taskId, String user, String status, String[] 
nominatedUsers) {
+        given()
+                .contentType(ContentType.JSON)
+                .when()
+                .queryParam("user", user)
+                .body(new TransitionInfo("nominate", Map.of("NOMINATED_USERS", 
nominatedUsers)))
+                .post(USER_TASKS_INSTANCE_TRANSITION_ENDPOINT, taskId)
+                .then()
+                .statusCode(200)
+                .body("id", equalTo(taskId))
+                .body("status.name", equalTo(status))
+                .body("status.terminate", equalTo(null))
+                .body("potentialUsers", hasItems(nominatedUsers));
+    }

Review Comment:
   I think that the integration test battery is so far not common for both 
platforms



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to