tkobayas commented on PR #6517: URL: https://github.com/apache/incubator-kie-drools/pull/6517#issuecomment-3521145923
Thank you @aner-perez , the fix looks pretty valid. Just one point, recently we have introduced `TrackingAgendaEventListener` which is exactly useful for test cases like yours. https://github.com/apache/incubator-kie-drools/blob/main/drools-core/src/main/java/org/drools/core/event/TrackingAgendaEventListener.java So your custom eventListener can be replaced like this: https://github.com/apache/incubator-kie-drools/blob/main/drools-model/drools-model-codegen/src/test/java/org/drools/model/codegen/execmodel/ActivationGroupDualFactMatchTest.java#L140-L141 https://github.com/apache/incubator-kie-drools/blob/main/drools-model/drools-model-codegen/src/test/java/org/drools/model/codegen/execmodel/ActivationGroupDualFactMatchTest.java#L175-L177 Please use TrackingAgendaEventListener. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
