danielzhe commented on code in PR #3351:
URL:
https://github.com/apache/incubator-kie-tools/pull/3351#discussion_r2535319773
##########
packages/online-editor/src/authSessions/AuthSessionSelect.tsx:
##########
@@ -87,9 +89,9 @@ export function AuthSessionSelect(props: {
const selectedAuthSessionId = useMemo(() => {
if (props.authSessionId && !authSession) {
- return "Authentication expired"; // authSession doesn't exist anymore
+ return i18n.devDeployments.common.authenticationExpired; // authSession
doesn't exist anymore
} else if (!props.authSessionId) {
- return "Select authentication"; // no authSession selected
+ return i18n.devDeployments.common.selectAuthentication; // no
authSession selected
Review Comment:
You need to add 'i18n.devDeployments.common.authenticationExpired' and
'i18n.devDeployments.common.selectAuthentication' in the array at line 98:
`[authSession, props.authSessionId,
i18n.devDeployments.common.authenticationExpired,
i18n.devDeployments.common.selectAuthentication]`
##########
packages/online-editor/src/devDeployments/DevDeploymentsDeployDropdownItems.tsx:
##########
@@ -92,20 +95,30 @@ export function
useDevDeploymentsDeployDropdownItems(workspace: ActiveWorkspace
onClick={onDeploy}
isDisabled={!authSessionId}
ouiaId={"deploy-to-dmn-dev-deployment-dropdown-button"}
- description="For development only!"
+ description={i18n.devDeployments.common.forDevelopmentOnly}
style={{ minWidth: "400px" }}
>
{workspace.files.length > 1 && (
<Flex flexWrap={{ default: "nowrap" }}>
<FlexItem>
- Deploy <b>{`"${workspace.descriptor.name}"`}</b>
+ <I18nWrappedTemplate
+ text={i18n.devDeployments.common.deployWorkspace}
+ interpolationMap={{
+ name: <b>{`"${workspace.descriptor.name}"`}</b>,
+ }}
+ />
</FlexItem>
</Flex>
)}
{workspace.files.length === 1 && (
<Flex flexWrap={{ default: "nowrap" }}>
<FlexItem>
- Deploy
<b>{`"${workspace.files[0].nameWithoutExtension}"`}</b>
+ <I18nWrappedTemplate
+ text={i18n.devDeployments.common.deployWorkspace}
+ interpolationMap={{
+ name:
<b>{`"${workspace.files[0].nameWithoutExtension}"`}</b>,
Review Comment:
Same. "React Hook useMemo has missing dependencies:
'i18n.devDeployments.common.deployWorkspace',
'i18n.devDeployments.common.forDevelopmentOnly', and
'i18n.desvDeployments.common.selectCloudForDev'"
At line 135 you have to add them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
