pefernan commented on code in PR #4126:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4126#discussion_r2537637679
##########
addons/common/task-management/src/main/java/org/kie/kogito/task/management/service/TaskManagementOperations.java:
##########
@@ -18,9 +18,11 @@
*/
package org.kie.kogito.task.management.service;
+import org.kie.kogito.auth.IdentityProvider;
+
public interface TaskManagementOperations {
- TaskInfo updateTask(String taskId, TaskInfo taskInfo, boolean replace);
+ TaskInfo updateTask(String taskId, TaskInfo taskInfo, boolean replace,
IdentityProvider orImpersonateIdentity);
Review Comment:
```suggestion
TaskInfo updateTask(String taskId, TaskInfo taskInfo, boolean replace,
IdentityProvider identity);
```
##########
quarkus/addons/task-management/runtime/src/main/java/org/kie/kogito/task/management/TaskManagementResource.java:
##########
@@ -68,20 +72,20 @@ public Response updateTask(
@QueryParam("user") final String user,
@QueryParam("group") final List<String> groups,
TaskInfo taskInfo) {
- taskService.updateTask(taskId, taskInfo, true);
+ taskService.updateTask(taskId, taskInfo, true,
identityProviderFactory.getOrImpersonateIdentity(user, groups));
Review Comment:
I'd prefer not to impersonate here because we want to ensure, why not adding
a new `getOrDefault` method on `IdentityProviderFactory` that returns either
the actual identity or a default one based on the user/grups args?
##########
addons/common/task-management/src/main/java/org/kie/kogito/task/management/service/TaskManagementService.java:
##########
@@ -18,26 +18,25 @@
*/
package org.kie.kogito.task.management.service;
-import java.util.Map;
+import java.util.*;
import java.util.Map.Entry;
-import java.util.Optional;
import java.util.function.BiConsumer;
import java.util.function.Consumer;
import java.util.function.Supplier;
+import org.kie.kogito.auth.IdentityProvider;
+import org.kie.kogito.auth.SecurityPolicy;
import org.kie.kogito.process.ProcessConfig;
import org.kie.kogito.services.uow.UnitOfWorkExecutor;
-import org.kie.kogito.usertask.UserTaskConfig;
-import org.kie.kogito.usertask.UserTaskInstance;
-import org.kie.kogito.usertask.UserTaskInstanceNotFoundException;
-import org.kie.kogito.usertask.UserTasks;
+import org.kie.kogito.usertask.*;
import org.kie.kogito.usertask.impl.DefaultUserTaskInstance;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
public class TaskManagementService implements TaskManagementOperations {
private static final Logger LOG =
LoggerFactory.getLogger(TaskManagementService.class);
+ public static final String WORKFLOW_ENGINE_USER = "WORKFLOW_ENGINE_USER";
Review Comment:
Is it used?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
