tkobayas commented on code in PR #6530:
URL:
https://github.com/apache/incubator-kie-drools/pull/6530#discussion_r2563129579
##########
drools-model/drools-model-codegen/src/main/java/org/drools/model/codegen/execmodel/generator/RuleContext.java:
##########
@@ -363,7 +363,11 @@ public void addRuleUnitVarOriginalType(String name,
Class<?> type) {
}
public Class<?> getRuleUnitVarType(String name) {
- Class<?> varType = ruleUnitVars.get( name );
+ return ruleUnitVars.get( name );
+ }
+
+ public Class<?> getTypeFromRuleUnitVarsAndScopedDeclarations(String name) {
+ Class<?> varType = getRuleUnitVarType( name );
Review Comment:
I split `getRuleUnitVarType` into `getRuleUnitVarType` and
`getTypeFromRuleUnitVarsAndScopedDeclarations` to clarify the method's
responsibility. Note that `scopedDeclarations.get("$p" )` below looks to be a
bug. I filed https://github.com/apache/incubator-kie-drools/issues/6531 as a
separated issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
