fjtirado commented on PR #4091: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/4091#issuecomment-3580614848
> Hi @fjtirado, apologies for the bad consequence of applying this change in that part of the code. As I wrote in the description, the idea is to unify the Tag management for all the model types we expose. The idea of having the TYPE - MODEL NAME pattern is to clearly state to which model (type and name) that subset of endpoints belongs. In the case of Kogito project with DMN, RULE and BPMN models, the previous approach didn't provide so much clarity on that. With the TYPE - MODEL NAME, the end user can now immediately know that information. I think that moving the TYPE in the description doesn't fully accomplish that goal of proving clarity to the end user: Indeed the information is present, but having it a tag level provides more visibility, in swagger. Moreover, in the process case, SpringBoot-based examples expose the tag in a different way than Quarkus-based example (see images above: person vs person-resources). Said so, my suggestion is to keep the new pattern and apply the change in the code you pointed out. I volunteer to do it, in case. WDYT? @yesamer I think just keeping the tag name as it was will do the trick. Basically removing the "Process -" prefix from the resource template. I need to do a PR anyway (because this functionality was not only broken by this change, but also broken by changes to [migrate](https://github.com/apache/incubator-kie-kogito-runtimes/pull/3935/files#diff-dbe9b4e217720b3b0fd2c9cb8bd8a5e83848069f7a91f17402f57c303f7ee4ffR49-R71) to quarkus 3.20 ) so if the pattern is really needed (as it seems), then I will change the code myself. Implementation note (for future ones): One problem of moving the code to the template if that you have to copy the "Process -" constant prefix in two different places: the template and the code that needs to check for it, I think it was better to use TagGenerator. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
