gitgabrio commented on code in PR #6537:
URL:
https://github.com/apache/incubator-kie-drools/pull/6537#discussion_r2571145614
##########
kie-dmn/kie-dmn-feel/src/main/java/org/kie/dmn/feel/lang/ast/BetweenNode.java:
##########
@@ -107,18 +109,27 @@ public Object evaluate(EvaluationContext ctx) {
ctx.notifyEvt(astEvent(severity, Msg.createMessage(Msg.IS_NULL,
"end")));
problem = true;
}
- if (problem && ctx.getFEELDialect() != FEELDialect.BFEEL) return null;
+ if (problem && ctx.getFEELDialect() != FEELDialect.BFEEL)
+ return null;
+
+ /*
+ * Object gte = InfixExecutorUtils.or(BooleanEvalHelper.compare(o_val,
o_s, ctx.getFEELDialect(), (l, r) -> l.compareTo(r) > 0),
+ * BooleanEvalHelper.isEqual(o_val, o_s, ctx.getFEELDialect()),
+ * ctx);
+ */ // do not use Java || to avoid potential NPE due to FEEL 3vl.
+ Object gte = GteExecutor.instance().evaluate(o_val, o_s, ctx);
Review Comment:
Hi @ChinchuAjith : great spot!
If you're sure that the behaviour is the same, then I think we may remove
altogether the usage of "GteExecutor".
The current path is:
`BetweenNode -> GteExecutor -> DialectHandler.executeGte`
but we may invoke DialectHandler directly from BewteenNode.
Please note that I created all those *Executor a couple of years ago, but
looking at this PR it seem we may slowly dismiss them: am I clear ? Does this
make sense ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
