gabriel-farache commented on code in PR #4094: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/4094#discussion_r2581731298
########## quarkus/extensions/kogito-quarkus-serverless-workflow-otel-extension/kogito-quarkus-serverless-workflow-otel/src/main/java/org/kie/kogito/quarkus/serverless/workflow/otel/NodeOtelEventListener.java: ########## @@ -0,0 +1,310 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.kie.kogito.quarkus.serverless.workflow.otel; + +import java.util.Date; +import java.util.Map; +import java.util.Set; +import java.util.concurrent.ConcurrentHashMap; + +import org.kie.api.event.process.ProcessCompletedEvent; +import org.kie.api.event.process.ProcessNodeLeftEvent; +import org.kie.api.event.process.ProcessNodeTriggeredEvent; +import org.kie.api.event.process.ProcessStartedEvent; +import org.kie.kogito.internal.process.event.DefaultKogitoProcessEventListener; +import org.kie.kogito.internal.process.runtime.KogitoNodeInstance; +import org.kie.kogito.internal.process.runtime.KogitoProcessInstance; +import org.kie.kogito.process.ProcessInstance; +import org.kie.kogito.quarkus.serverless.workflow.otel.config.SonataFlowOtelConfig; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import io.opentelemetry.api.trace.Span; + +import static org.kie.kogito.quarkus.serverless.workflow.otel.SonataFlowOtelAttributes.EventDescriptions; +import static org.kie.kogito.quarkus.serverless.workflow.otel.SonataFlowOtelAttributes.Events; +import static org.kie.kogito.quarkus.serverless.workflow.otel.SonataFlowOtelAttributes.NodePatterns; +import static org.kie.kogito.quarkus.serverless.workflow.otel.SonataFlowOtelAttributes.ProcessStates; + +public class NodeOtelEventListener extends DefaultKogitoProcessEventListener { + + record NodeProcessDetails(String processInstanceId, String processId, String processVersion, String processState, String nodeId) { + } + + private static final Logger LOGGER = LoggerFactory.getLogger(NodeOtelEventListener.class); + + private final NodeSpanManager spanManager; + private final SonataFlowOtelConfig config; + private final ProcessEventHandler processEventHandler; + private final HeaderContextExtractor headerExtractor; + private final Set<String> processedErrors = ConcurrentHashMap.newKeySet(); + + public NodeOtelEventListener(NodeSpanManager spanManager, SonataFlowOtelConfig config, HeaderContextExtractor headerExtractor) { + this.spanManager = spanManager; + this.config = config; + this.headerExtractor = headerExtractor; + this.processEventHandler = new ProcessEventHandler(spanManager, config); + LOGGER.debug("NodeOtelEventListener initialized"); + } + + @Override + public void afterProcessStarted(ProcessStartedEvent event) { + LOGGER.debug("Process started event received - start event will be added in beforeNodeTriggered"); + } + + @Override + public void beforeNodeTriggered(ProcessNodeTriggeredEvent event) { + try { + NodeProcessDetails details = extractNodeAndProcessDetails(event); + + if (isInternalNode(details.nodeId())) { + LOGGER.trace("Skipping internal node: {}", details.nodeId()); + return; + } + + LOGGER.debug("Node triggered: {} for process instance {} (process: {})", + details.nodeId(), details.processInstanceId(), details.processId()); + + Map<String, String> extractedContext = OtelContextHolder.getExtractedContext(); + if (extractedContext.isEmpty()) { + extractedContext = handleContextReestablishment( + (KogitoProcessInstance) event.getProcessInstance(), details.processInstanceId()); + } + + createAndConfigureNodeSpan(details.processInstanceId(), details.processId(), + details.processVersion(), details.processState(), details.nodeId(), extractedContext); + + } catch (Exception e) { + LOGGER.error("Error in beforeNodeTriggered: {}", e.getMessage(), e); + } + } + + private NodeProcessDetails extractNodeAndProcessDetails(ProcessNodeTriggeredEvent event) { + KogitoNodeInstance nodeInstance = (KogitoNodeInstance) event.getNodeInstance(); + KogitoProcessInstance processInstance = (KogitoProcessInstance) event.getProcessInstance(); + + String processInstanceId = processInstance.getId(); + String processId = processInstance.getProcessId(); + String processVersion = processInstance.getProcessVersion(); + String processState = getProcessState(processInstance.getState()); + String nodeId = nodeInstance.getNodeName(); + + return new NodeProcessDetails(processInstanceId, processId, processVersion, processState, nodeId); + } + + private Map<String, String> handleContextReestablishment(KogitoProcessInstance processInstance, String processInstanceId) { + try { + Map<String, java.util.List<String>> processHeaders = processInstance.getHeaders(); + if (processHeaders != null && !processHeaders.isEmpty()) { + Map<String, String> headerContext = headerExtractor.extractFromProcessHeaders(processHeaders); + if (!headerContext.isEmpty()) { + populateMDCFromContext(headerContext); + LOGGER.debug("Re-established context from process headers for process instance {}: {}", + processInstanceId, headerContext.keySet()); + return headerContext; + } + } + } catch (Exception e) { + LOGGER.debug("Failed to extract context from process headers: {}", e.getMessage()); + } + return Map.of(); + } + + private void createAndConfigureNodeSpan(String processInstanceId, String processId, String processVersion, String processState, String nodeId, Map<String, String> extractedContext) { + Span span = spanManager.createNodeSpanWithContext(processInstanceId, processId, processVersion, processState, nodeId, extractedContext); + + if (span != null) { Review Comment: in the NodeSpanManager, I added `LOGGER.debug("Span creation disabled");` in the `createNodeSpan` method as that's the only reason why the span would be null here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
