danielzhe commented on code in PR #3370:
URL:
https://github.com/apache/incubator-kie-tools/pull/3370#discussion_r2586413760
##########
packages/dmn-feel-antlr4-parser/src/parser/IdentifiersRepository.ts:
##########
@@ -825,9 +827,13 @@ export class IdentifiersRepository {
private addInputVariable(parent: IdentifierContext, requirement:
DmnInformationRequirement) {
if (requirement.requiredDecision) {
-
parent.inputIdentifiers.push(requirement.requiredDecision["@_href"]?.replace("#",
""));
+ parent.inputIdentifiers.push(
+ requirement.requiredDecision["@_href"]?.replace(this._localNamespace,
"").replace("#", "")
Review Comment:
We don't care about local namespace, that's why we remove if it is present.
For included models, the code that adds the variables is another, so that's
why we can safely remove the namespace: if we are here, it is a local node for
sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
