ChinchuAjith commented on code in PR #6537:
URL:
https://github.com/apache/incubator-kie-drools/pull/6537#discussion_r2589080560
##########
kie-dmn/kie-dmn-feel/src/test/java/org/kie/dmn/feel/util/BooleanEvalHelperTest.java:
##########
@@ -68,21 +61,24 @@ void getBooleanOrDialectDefaultBFEEL() {
assertThat(getBooleanOrDialectDefault(null,
FEELDialect.BFEEL)).isEqualTo(Boolean.FALSE);
}
- @Test
- void getFalseOrDialectDefaultFEEL() {
- assertThat(getFalseOrDialectDefault(false,
FEELDialect.FEEL)).isEqualTo(Boolean.FALSE);
- assertThat(getFalseOrDialectDefault(true, FEELDialect.FEEL)).isNull();
- assertThat(getFalseOrDialectDefault("true",
FEELDialect.FEEL)).isNull();
- assertThat(getFalseOrDialectDefault(null, FEELDialect.FEEL)).isNull();
- }
-
- @Test
- void getFalseOrDialectDefaultBFEEL() {
- assertThat(getFalseOrDialectDefault(false,
FEELDialect.BFEEL)).isEqualTo(Boolean.FALSE);
- assertThat(getFalseOrDialectDefault(true,
FEELDialect.BFEEL)).isEqualTo(Boolean.FALSE);
- assertThat(getFalseOrDialectDefault("true",
FEELDialect.BFEEL)).isEqualTo(Boolean.FALSE);
- assertThat(getFalseOrDialectDefault(null,
FEELDialect.BFEEL)).isEqualTo(Boolean.FALSE);
- }
+ //TODO to be removed
+ /*
+ * @Test
+ * void getFalseOrDialectDefaultFEEL() {
+ * assertThat(getFalseOrDialectDefault(false,
FEELDialect.FEEL)).isEqualTo(Boolean.FALSE);
+ * assertThat(getFalseOrDialectDefault(true, FEELDialect.FEEL)).isNull();
+ * assertThat(getFalseOrDialectDefault("true", FEELDialect.FEEL)).isNull();
+ * assertThat(getFalseOrDialectDefault(null, FEELDialect.FEEL)).isNull();
+ * }
+ *
+ * @Test
+ * void getFalseOrDialectDefaultBFEEL() {
+ * assertThat(getFalseOrDialectDefault(false,
FEELDialect.BFEEL)).isEqualTo(Boolean.FALSE);
+ * assertThat(getFalseOrDialectDefault(true,
FEELDialect.BFEEL)).isEqualTo(Boolean.FALSE);
+ * assertThat(getFalseOrDialectDefault("true",
FEELDialect.BFEEL)).isEqualTo(Boolean.FALSE);
+ * assertThat(getFalseOrDialectDefault(null,
FEELDialect.BFEEL)).isEqualTo(Boolean.FALSE);
+ * }
+ */
Review Comment:
Keeping this as of now as it will be handled later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
