fantonangeli commented on code in PR #4078:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4078#discussion_r2602231237
##########
quarkus/extensions/kogito-quarkus-serverless-workflow-extension/kogito-quarkus-serverless-workflow/pom.xml:
##########
@@ -34,6 +34,9 @@
<properties>
<java.module.name>org.kie.kogito.serverless.workflow</java.module.name>
+
<SONATAFLOW_WORKFLOW_ENDPOINT_WEBAPP_DOCLINK_HREF>https://sonataflow.org/serverlessworkflow/latest/index.html</SONATAFLOW_WORKFLOW_ENDPOINT_WEBAPP_DOCLINK_HREF>
+ <SONATAFLOW_WORKFLOW_ENDPOINT_WEBAPP_DOCLINK_TEXT>Sonataflow
Docs</SONATAFLOW_WORKFLOW_ENDPOINT_WEBAPP_DOCLINK_TEXT>
+
<SONATAFLOW_WORKFLOW_ENDPOINT_WEBAPP_LOGO>favicon.svg</SONATAFLOW_WORKFLOW_ENDPOINT_WEBAPP_LOGO>
Review Comment:
Please also add the var `SONATAFLOW_WORKFLOW_ENDPOINT_WEBAPP_TITLE`
##########
quarkus/extensions/kogito-quarkus-serverless-workflow-extension/kogito-quarkus-serverless-workflow/src/main/resources/META-INF/resources/index.html:
##########
@@ -0,0 +1,62 @@
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one
+ ~ or more contributor license agreements. See the NOTICE file
+ ~ distributed with this work for additional information
+ ~ regarding copyright ownership. The ASF licenses this file
+ ~ to you under the Apache License, Version 2.0 (the
+ ~ "License"); you may not use this file except in compliance
+ ~ with the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing,
+ ~ software distributed under the License is distributed on an
+ ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ ~ KIND, either express or implied. See the License for the
+ ~ specific language governing permissions and limitations
+ ~ under the License.
+-->
+
+<!DOCTYPE html>
+<html lang="en">
+ <head>
+ <meta charset="UTF-8" />
+ <meta name="viewport" content="width=device-width, initial-scale=1.0" />
+ <title>SONATAFLOW WORKFLOW ENDPOINT</title>
Review Comment:
@kumaradityaraj I apologise, after my review, I saw we should use a
variable in the `pom.xml` to let us customise the title, in the same way you
did for `SONATAFLOW_WORKFLOW_ENDPOINT_WEBAPP_DOCLINK_TEXT`.
We can name it `SONATAFLOW_WORKFLOW_ENDPOINT_WEBAPP_TITLE`
##########
quarkus/extensions/kogito-quarkus-serverless-workflow-extension/kogito-quarkus-serverless-workflow/src/main/resources/META-INF/resources/index.html:
##########
@@ -0,0 +1,62 @@
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one
+ ~ or more contributor license agreements. See the NOTICE file
+ ~ distributed with this work for additional information
+ ~ regarding copyright ownership. The ASF licenses this file
+ ~ to you under the Apache License, Version 2.0 (the
+ ~ "License"); you may not use this file except in compliance
+ ~ with the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing,
+ ~ software distributed under the License is distributed on an
+ ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ ~ KIND, either express or implied. See the License for the
+ ~ specific language governing permissions and limitations
+ ~ under the License.
+-->
+
+<!DOCTYPE html>
+<html lang="en">
+ <head>
+ <meta charset="UTF-8" />
+ <meta name="viewport" content="width=device-width, initial-scale=1.0" />
+ <title>SONATAFLOW WORKFLOW ENDPOINT</title>
+ <link rel="stylesheet" href="styles.css" />
+ <link
+ rel="shortcut icon"
+ type="image/x-icon"
+ href="${SONATAFLOW_WORKFLOW_ENDPOINT_WEBAPP_LOGO}"
+ />
+ </head>
+ <body>
+ <div class="maindiv">
+ <div class="container">
+ <div class="logo" style="display: flex; justify-content: center">
+ <img
+ src="${SONATAFLOW_WORKFLOW_ENDPOINT_WEBAPP_LOGO}"
+ alt="KIE Logo"
+ />
+ <h1>SONATAFLOW WORKFLOW ENDPOINT</h1>
Review Comment:
Like in my previous comment, please use the new var
`SONATAFLOW_WORKFLOW_ENDPOINT_WEBAPP_TITLE`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
