fjtirado commented on PR #4139:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4139#issuecomment-3641906175
> LGTM, great work.
>
> @fjtirado So the algorithm is like this: if the function is defined like
this:
>
> ```
> "functions": [
> {
> "name": "multiplyAllByAndSum",
> "type": "custom",
> "operation": "rest:post:https://myservice/my-paty
> }
> ```
>
> Then, the `https://myservice/my-paty`is used as is. i.e., wins over a
potential protocol and port configured parameters.
>
> Otherwise, the `quarkus.ws.fuctions.multiplyAllByAndSum` parameters are
used. Including the new added "protocol" paramter.
>
> **Please document it somewere here:**
https://sonataflow.org/serverlessworkflow/main/core/custom-functions-support.html#con-func-rest,
otherwise, unless doing the code reading it's imposible for users to know how
this work, and next time, theyll fall into the same issue.
@wmedvede For the documentation part, in my opinion, the only missing thing
is the new protocol property. If you feel the writing should be improved,
please feel free to do so (I already tried my best and I believe that, "when
using relative paths" already hinted that when using absolute path the function
was ignored)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
