handreyrc commented on code in PR #3252: URL: https://github.com/apache/incubator-kie-tools/pull/3252#discussion_r2616004234
########## packages/serverless-workflow-editor/src/SwfEditor.css: ########## @@ -0,0 +1,563 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/* (begin) global */ +.kie-swf-editor--root { + height: 100%; +} + +.kie-tools--swf-editor--diagram-container { + height: 100%; + position: relative; +} + +.kie-swf-editor--bee-container { + position: relative; + height: 100%; + display: flex; + flex-direction: column; + overflow: auto; + user-select: none; + padding-left: 16px; +} +/* (end) global */ + +/* (begin) diagram empty state */ +.kie-swf-editor--diagram-empty-state { + border: 1px solid lightgray; + backdrop-filter: blur(4px); + background: rgb(255, 255, 255, 60%); + border-radius: 16px; + padding: 16px; + pointer-events: all; + box-shadow: 0 0 60px 20px #e1e1e1; +} +/* (end) diagram empty state */ + +/* (begin) nodes */ +.kie-swf-editor--node { + height: 100%; + width: 100%; + padding: 10px; + display: flex; + align-items: center; + justify-content: center; + word-break: break-word; + overflow: hidden; + -webkit-line-clamp: 2; /* number of lines to show */ + line-clamp: 2; + -webkit-box-orient: vertical; + text-align: center; + position: absolute; + z-index: 10; + top: 0; + left: 0; + overflow: visible; + z-index: 10000; /* Makes the data type node panel appear correctly, on top of the node */ +} +.kie-swf-editor--node:focus { + outline: none; +} +.kie-swf-editor--node.dimmed, +.kie-swf-editor--node-shape.dimmed, +.kie-swf-editor--generic-node.dimmed { + opacity: 0.3; + pointer-events: none; +} +.kie-swf-editor--node-shape { + position: absolute; + top: 0; + left: 0; + width: 100%; + height: 100%; + pointer-events: none; + z-index: 1; +} +.kie-swf-editor--generic-node { + outline: none; + width: 100%; + height: 100%; +} + +.kie-swf-editor--unknown-node { + color: red; +} +/* (end) nodes */ + +/* (begin) palette */ +.kie-swf-editor--palette { + width: 42px; + background: #fff; + border-radius: 40px; + border: 1px solid black; +} +.kie-swf-editor--palette:hover { + box-shadow: 4px 4px 2px 0px rgb(127 127 127); +} + +.kie-swf-editor--palette.pulse { + animation: pulse 3s infinite; +} + +@keyframes pulse { + 0% { + box-shadow: 0 0 0 0 rgba(0, 0, 0, 0.3); + } + + 70% { + box-shadow: 0 0 20px 20px rgba(0, 0, 0, 0); + } + + 100% { + box-shadow: 0 0 20px 0 rgba(0, 0, 0, 0); + } +} + +.kie-swf-editor--palette-button { + margin: 0; + margin-bottom: 8px; + padding: 0; + width: 40px; + height: 40px; + max-width: 40px; + border-radius: 40px; + border: 0; + background: white; +} +.kie-swf-editor--palette-button:hover { + filter: brightness(95%); + cursor: grab; +} +.kie-swf-editor--palette-button:active { + filter: brightness(90%); + cursor: grabbing; +} +/* (end) palette */ + +/* (begin) version popover */ +.kie-swf-editor--version-popover .pf-v5-c-popover__body { + padding: 0; +} +/* (end) version popover */ + +/* (begin) autolayout panel toggle */ +.kie-swf-editor--autolayout-panel-toggle { + width: 42px; + background: #fff; + border-radius: 40px; + border: 1px solid black; +} +.kie-swf-editor--autolayout-panel-toggle:not(:last-child) { + margin-right: 16px; +} + +.kie-swf-editor--autolayout-panel-toggle:hover { + box-shadow: -4px 4px 2px 0px rgb(127 127 127); +} +.kie-swf-editor--autolayout-panel-toggle-button { + margin: 0; + width: 40px; + height: 40px; + max-width: 40px; + border-radius: 40px; + border: 0; + background: white; +} +.kie-swf-editor--autolayout-panel-toggle-button:hover { + filter: brightness(95%); +} +.kie-swf-editor--autolayout-panel-toggle-button:active { + filter: brightness(90%); +} +/* (end) autolayout panel toggle */ + +/* (begin) evaluation-highlights panel toggle */ +.kie-swf-editor--evaluation-highlights-panel-toggle { + min-width: 190px; +} +/* (end) evaluation-highlights panel toggle */ Review Comment: You are correct, if it is DMN specific it must be removed. However, It is not totally true for all the cases. For example the overlay panel, palette, properties panel... all of it will be put back for the editing mode soon. There are also situations where it does not worthwhile to refactor the code for now and then have to undo it later. This PR is an entry point for team collaboration. it is a Milestone 0, so an MVP is the next step. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
