fantonangeli commented on code in PR #3252:
URL:
https://github.com/apache/incubator-kie-tools/pull/3252#discussion_r2622978293
##########
packages/serverless-workflow-editor/package.json:
##########
@@ -0,0 +1,117 @@
+{
+ "name": "@kie-tools/serverless-workflow-editor",
+ "version": "0.0.0",
+ "description": "",
+ "license": "Apache-2.0",
+ "keywords": [],
+ "homepage": "https://github.com/apache/incubator-kie-tools";,
+ "repository": {
+ "type": "git",
+ "url": "https://github.com/apache/incubator-kie-tools.git";
+ },
+ "bugs": {
+ "url": "https://github.com/apache/incubator-kie-tools/issues";
+ },
+ "files": [
+ "dist",
+ "src"
+ ],
+ "scripts": {
+ "build:dev": "rimraf dist && pnpm copy:css && tsc -p tsconfig.json",
+ "build:prod": "rimraf dist && pnpm copy:css && pnpm lint && tsc -p
tsconfig.json && pnpm test-e2e && pnpm test",
+ "build:storybook": "rimraf dist-storybook && NODE_ENV=development
storybook build -o dist-storybook",
+ "copy:css": "copyfiles -u 1 \"src/**/*.{sass,scss,css}\" dist/",
+ "lint": "run-script-if --bool \"$(build-env linters.run)\" --then
\"kie-tools--eslint ./src\"",
+ "start": "run-script-os",
+ "start:linux:darwin": "cross-env STORYBOOK_PORT=$(build-env
swfEditor.storybook.port) pnpm kie-tools--storybook --storybookArgs=\"dev
--no-open\"",
+ "start:win32": "pnpm powershell \"cross-env STORYBOOK_PORT=$(build-env
swfEditor.storybook.port) pnpm kie-tools--storybook --storybookArgs='dev
--no-open'",
+ "test": "run-script-if --ignore-errors \"$(build-env
tests.ignoreFailures)\" --bool \"$(build-env tests.run)\" --then \"jest
--silent --verbose --passWithNoTests\"",
+ "test-e2e": "run-script-if --ignore-errors \"$(build-env
endToEndTests.ignoreFailures)\" --bool \"$(build-env endToEndTests.run)\"
--then \"pnpm test-e2e:condition\"",
+ "test-e2e:condition": "run-script-if --bool \"$(build-env
endToEndTests.containerized)\" --then \"pnpm rimraf ./dist-tests-e2e\" \"pnpm
test-e2e:container:start\" --else \"pnpm rimraf ./dist-tests-e2e\" \"pnpm
test-e2e:run\"",
+ "test-e2e:container:bash": "docker exec -it
kie-tools-playwright-containerization-serverless-workflow-editor /bin/bash -c
\"cd incubator-kie-tools/packages/serverless-workflow-editor && exec
/bin/bash\"",
+ "test-e2e:container:down": "docker compose -f
./tests-e2e/__containerization__/playwright-docker-compose.yml down",
+ "test-e2e:container:run": "docker exec -i
kie-tools-playwright-containerization-serverless-workflow-editor /bin/bash -c
\"cd incubator-kie-tools/packages/serverless-workflow-editor && pnpm
test-e2e:run\"",
+ "test-e2e:container:shell": "start-server-and-test 'pnpm start'
http://localhost:$(build-env swfEditor.storybook.port)/iframe.html 'pnpm
test-e2e:container:up && pnpm test-e2e:container:bash'",
+ "test-e2e:container:start": "start-server-and-test 'pnpm start'
http://localhost:$(build-env swfEditor.storybook.port)/iframe.html 'pnpm
test-e2e:container:up && pnpm test-e2e:container:run'",
+ "test-e2e:container:up": "cross-env STREAM_NAME=$(build-env
root.streamName) KIE_TOOLS_PLAYWRIGHT_CONTAINER__PORT=$(build-env
swfEditor.storybook.port) run-script-if --bool \"${CI}\" --then \"docker
compose -f ./tests-e2e/__containerization__/playwright-docker-compose.yml -f
./tests-e2e/__containerization__/playwright-docker-compose.ci.yml up -d\"
--else \"docker compose -f
./tests-e2e/__containerization__/playwright-docker-compose.yml up -d\"",
+ "test-e2e:open": "pnpm exec playwright show-report dist-tests-e2e/reports",
+ "test-e2e:run": "pnpm exec playwright test"
+ },
+ "dependencies": {
+ "@kie-tools-core/i18n": "workspace:*",
+ "@kie-tools-core/operating-system": "workspace:*",
+ "@kie-tools-core/patternfly-base": "workspace:*",
+ "@kie-tools-core/react-hooks": "workspace:*",
+ "@kie-tools-core/switch-expression-ts": "workspace:*",
+ "@kie-tools/i18n-common-dictionary": "workspace:*",
+ "@kie-tools/xml-parser-ts": "workspace:*",
+ "@patternfly/react-core": "^5.4.1",
+ "@patternfly/react-icons": "^5.4.1",
+ "@patternfly/react-styles": "^5.4.0",
+ "@serverlessworkflow/sdk-typescript": "^0.8.4",
+ "@visx/text": "^3.3.0",
+ "d3-drag": "^3.0.0",
+ "d3-selection": "^3.0.0",
+ "elkjs": "^0.9.1",
Review Comment:
It seems we are not the only ones having this [license
issue](https://github.com/kieler/elkjs/issues?q=is%3Aissue%20license), but they
have no plan to replace it.
I see this library it's used only in 4 points:
```
packages/dmn-editor/src/autolayout/autoLayoutInfo.ts|23| import ELK, * as
Elk from "elkjs/lib/elk.bundled.js";
packages/dmn-editor/src/mutations/applyAutoLayoutToDrd.ts|23| import * as
Elk from "elkjs/lib/elk.bundled.js";
packages/serverless-workflow-editor/src/autolayout/autoLayoutInfo.ts|20|
import ELK, * as Elk from "elkjs/lib/elk.bundled.js";
packages/serverless-workflow-editor/src/mutations/applyAutoLayoutToSwf.ts|20|
import * as Elk from "elkjs/lib/elk.bundled.js";
```
and we use it just for interfaces. Maybe we can create some custom
interfaces in a separate PR and remove this dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
