wmedvede commented on code in PR #4151:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4151#discussion_r2623871961
##########
quarkus/addons/events/process/runtime/src/main/java/org/kie/kogito/events/process/AbstractMessagingEventPublisher.java:
##########
@@ -77,11 +77,11 @@ public abstract class AbstractMessagingEventPublisher
implements EventPublisher
@PostConstruct
public void init() {
decoratorProvider = decoratorProviderInstance.isResolvable() ?
decoratorProviderInstance.get() : null;
- processDefinitionConsumer =
eventsRuntimeConfig.isProcessInstancesPropagateError() ? new
BlockingMessageEmitter(processDefinitionEventsEmitter,
PROCESS_DEFINITIONS_TOPIC_NAME)
Review Comment:
Old bug maybe **processDefinitionConsumer** =
eventsRuntimeConfig.**isProcessInstancesPropagateError**()
##########
quarkus/addons/events/process/runtime/src/main/java/org/kie/kogito/events/process/AbstractMessagingEventPublisher.java:
##########
@@ -77,11 +77,11 @@ public abstract class AbstractMessagingEventPublisher
implements EventPublisher
@PostConstruct
public void init() {
decoratorProvider = decoratorProviderInstance.isResolvable() ?
decoratorProviderInstance.get() : null;
- processDefinitionConsumer =
eventsRuntimeConfig.isProcessInstancesPropagateError() ? new
BlockingMessageEmitter(processDefinitionEventsEmitter,
PROCESS_DEFINITIONS_TOPIC_NAME)
+ processDefinitionConsumer =
eventsRuntimeConfig.processDefinitionsErrorsPropagate() ? new
BlockingMessageEmitter(processDefinitionEventsEmitter,
PROCESS_DEFINITIONS_TOPIC_NAME)
: new ReactiveMessageEmitter(processDefinitionEventsEmitter,
PROCESS_DEFINITIONS_TOPIC_NAME);
- processInstanceConsumer =
eventsRuntimeConfig.isProcessDefinitionPropagateError() ? new
BlockingMessageEmitter(processInstancesEventsEmitter,
PROCESS_INSTANCES_TOPIC_NAME)
Review Comment:
same here **processInstanceConsumer** =
eventsRuntimeConfig**.isProcessDefinitionPropagateError()**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
