ljmotta commented on code in PR #3382: URL: https://github.com/apache/incubator-kie-tools/pull/3382#discussion_r2635294387
########## packages/playwright-base/README.md: ########## @@ -19,35 +19,15 @@ ## Overview -This package collects common configurations to run end-to-end Playwright tests. - -## Installing Playwright deps - -Currently, all Playwright end-to-end tests run inside containers. If you need to debug a test, we recommend doing so on the host machine. To do this, you need to install the Playwright dependencies. Use the `PLAYWRIGHT_BASE__installDeps` environment variable during the bootstrap phase to install all the required dependencies. - -```sh -# in the `kie-tools` root -PLAYWRIGHT_BASE__installDeps=true pnpm bootstrap -``` - -or - -```sh -# in the `kie-tools` root -PLAYWRIGHT_BASE__installDeps=true pnpm bootstrap -F playwright-base -``` - -> **i NOTE** -> -> Since this step install the Playwright browsers, it requires sudo permision. +This package collects common configurations to run end-to-end Playwright tests. Currently, all Playwright end-to-end tests run inside containers. If you need to debug a test, we recommend doing so on the host machine, refer to the [Installing Playwright deps](#Installing-Playwright-deps) ## Using containers to generate screenshots Each operating system has slight variations in UI, even within the same browser. These differences can cause screenshot comparison tests to fail. To address this issue and ensure a stable environment with consistent test results locally and in CI, containers can be used. Running Playwright tests inside a container that is also used in the CI environment makes screenshot tests reproducible, regardless of the host OS. > **ℹ️ NOTE** > -> Due to compatibility issues, this containerization solution cannot yet be used on native Windows and requires running it directly within WSL (Windows Subsystem for Linux). Also, Linux arm64 doesn't support Google Chrome, and due to this caveat, some tests will be disabled for this arch. +> Due to compatibility issues, this containerization solution cannot yet be used on native Windows and requires running it directly within WSL (Windows Subsystem for Linux). Also, Linux arm64 doesn't support Google Chrome, and due to this caveat, Google Chrome tests in macOS arm are disabled in some packages. Review Comment: Actually, I'll update to something like WDYT @thiagoelg : > Due to compatibility issues, this containerization solution cannot yet be used on native Windows and requires running it directly within WSL (Windows Subsystem for Linux). Additionally, Google Chrome is not available for Linux on ARM64, so any Chrome-based tests in an ARM64 container must be disabled. At present, tests run on AMD64 containers to ensure all browsers and test scenarios execute safely. We don't have any tests running on arm64, some tests are disabled on Apple Silicon due to historical reasons. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
