Copilot commented on code in PR #3399:
URL:
https://github.com/apache/incubator-kie-tools/pull/3399#discussion_r2711341560
##########
packages/dmn-feel-antlr4-parser/src/parser/grammar/ParserHelper.ts:
##########
@@ -247,6 +247,14 @@ export class ParserHelper {
variableName
)
);
+ } else if (qn.length > 1) {
+ // This is a special case, when we have something.ReservedWord.
+ // For example, a.time, being 'time' a reserved word for the
function 'time()'.
+ // So, if it is a part of a qualified name, it must be a
FeelSyntacticSymbolNature.Unknown.
Review Comment:
Extra space in comment. "must be a FeelSyntacticSymbolNature" should be
"must be a FeelSyntacticSymbolNature" (with only one space).
```suggestion
// So, if it is a part of a qualified name, it must be a
FeelSyntacticSymbolNature.Unknown.
```
##########
packages/dmn-feel-antlr4-parser/src/parser/grammar/ParserHelper.ts:
##########
@@ -247,6 +247,14 @@ export class ParserHelper {
variableName
)
);
+ } else if (qn.length > 1) {
+ // This is a special case, when we have something.ReservedWord.
+ // For example, a.time, being 'time' a reserved word for the
function 'time()'.
+ // So, if it is a part of a qualified name, it must be a
FeelSyntacticSymbolNature.Unknown.
+ // It if it not, then we just ignore because it must be a function
call (time()).
Review Comment:
Grammatical error in comment. "It if it not" should be "If it is not".
```suggestion
// If it is not, then we just ignore because it must be a function
call (time()).
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
