gitgabrio commented on issue #6561: URL: https://github.com/apache/incubator-kie-drools/issues/6561#issuecomment-3798566248
THanks @tkobayas While you're at it, maybe it would be nice to refactor a bit the overall implementation, since currently it (ouch) requires the definition of the same set of values (the language levels) in two different places: 1. [property definition](https://github.com/apache/incubator-kie-drools/blob/fe6decc777e02e22a40e822dd56738c553396f5a/kie-memory-compiler/src/main/java/org/kie/memorycompiler/JavaConfiguration.java#L43) 2. `if` [evaluation](https://github.com/apache/incubator-kie-drools/blob/fe6decc777e02e22a40e822dd56738c553396f5a/kie-memory-compiler/src/main/java/org/kie/memorycompiler/JavaConfiguration.java#L88) Side-note: the values returned by the `if` evaluation are not taken from the property, and this introduce another potential point of error Thanks again, please let me know if my suggestion is clear! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
