Copilot commented on code in PR #2298:
URL:
https://github.com/apache/incubator-kie-kogito-apps/pull/2298#discussion_r2753059720
##########
data-audit/kogito-addons-data-audit-jpa/kogito-addons-data-audit-jpa-common/pom.xml:
##########
@@ -100,9 +100,8 @@
<scope>test</scope>
</dependency>
<dependency>
- <groupId>org.hibernate</groupId>
- <artifactId>hibernate-entitymanager</artifactId>
- <version>5.6.12.Final</version>
+ <groupId>org.hibernate.orm</groupId>
+ <artifactId>hibernate-core</artifactId>
Review Comment:
The hibernate-core dependency is now using groupId org.hibernate.orm without
an explicit version. This dependency should either have:
1. An explicit version tag referencing ${version.org.hibernate}, OR
2. Be managed in the dependencyManagement section of
kogito-apps-build-parent/pom.xml
Currently, hibernate-ant is managed in the parent (line 202-206 of
kogito-apps-build-parent/pom.xml) with version ${version.org.hibernate}, but
hibernate-core is not. Please verify that hibernate-core's version is properly
managed in one of the imported BOMs (kogito-quarkus-bom or kogito-apps-bom). If
it's not managed there, consider adding explicit version management to ensure
consistent versions across all modules.
```suggestion
<artifactId>hibernate-core</artifactId>
<version>${version.org.hibernate}</version>
```
##########
kogito-apps-build-parent/pom.xml:
##########
@@ -62,7 +62,7 @@
<!-- OptaPlanner version -->
<version.org.optaplanner>${project.version}</version.org.optaplanner>
- <version.org.hibernate>6.6.11.Final</version.org.hibernate>
+ <version.org.hibernate>7.1.14.Final</version.org.hibernate>
Review Comment:
The PR title explicitly states "[DO-NOT-MERGE]". This indicates that this
pull request is not intended to be merged in its current state and likely
requires additional work, review, or coordination with other changes before it
can be merged.
##########
jobs/kogito-addons-embedded-jobs-jpa/kogito-addons-common-embedded-jobs-jpa/pom.xml:
##########
@@ -109,9 +109,8 @@
<scope>test</scope>
</dependency>
<dependency>
- <groupId>org.hibernate</groupId>
- <artifactId>hibernate-entitymanager</artifactId>
- <version>5.6.12.Final</version>
+ <groupId>org.hibernate.orm</groupId>
+ <artifactId>hibernate-core</artifactId>
<scope>test</scope>
Review Comment:
The hibernate-core dependency is now using groupId org.hibernate.orm without
an explicit version. This dependency should either have:
1. An explicit version tag referencing ${version.org.hibernate}, OR
2. Be managed in the dependencyManagement section of
kogito-apps-build-parent/pom.xml
Currently, hibernate-ant is managed in the parent (line 202-206 of
kogito-apps-build-parent/pom.xml) with version ${version.org.hibernate}, but
hibernate-core is not. Please verify that hibernate-core's version is properly
managed in one of the imported BOMs (kogito-quarkus-bom or kogito-apps-bom). If
it's not managed there, consider adding explicit version management to ensure
consistent versions across all modules.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
