fjtirado commented on code in PR #4146:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4146#discussion_r2758827446
##########
jbpm/jbpm-flow/src/main/java/org/kie/kogito/process/impl/ProcessServiceImpl.java:
##########
@@ -160,12 +161,16 @@ public <T extends MappableToModel<R>, R> Optional<R>
updatePartial(Process<T> pr
@Override
public <T extends MappableToModel<R>, R> Optional<R>
signalProcessInstance(Process<T> process, String id, Object data, String
signalName) {
- return
UnitOfWorkExecutor.executeInUnitOfWork(application.unitOfWorkManager(),
- () -> process.instances().findById(id)
+ return Optional.ofNullable(UnitOfWorkExecutor.executeInUnitOfWork(
Review Comment:
Anyway, I think the only change needed here is the acceptingEventType. The
exception should not be theown by this method but the rest layer should check
for empty optional and compose the message with the 412 (not 400 o 404) or
equivalent to the rest client.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
