ljmotta commented on code in PR #3397:
URL:
https://github.com/apache/incubator-kie-tools/pull/3397#discussion_r2763993914
##########
packages/dmn-feel-antlr4-parser/src/parser/FeelFunctionReturningTypes.ts:
##########
@@ -110,16 +110,16 @@ export class FeelFunctionReturningTypes {
["string", BuiltInTypes.String],
["string join", BuiltInTypes.String],
["string length", BuiltInTypes.Number],
- ["subList", BuiltInTypes.List],
- ["subString after", BuiltInTypes.String],
- ["subString before", BuiltInTypes.String],
- ["subString", BuiltInTypes.String],
+ ["sublist", BuiltInTypes.List],
+ ["substring after", BuiltInTypes.String],
+ ["substring before", BuiltInTypes.String],
+ ["substring", BuiltInTypes.String],
["sum", BuiltInTypes.Number],
["time", BuiltInTypes.Time],
["today", BuiltInTypes.Date],
["union", BuiltInTypes.List],
["upper case", BuiltInTypes.String],
["week of year", BuiltInTypes.Number],
- ["years and months duration", BuiltInTypes.YearsAndMonthsDuration],
+ ["years and months duration", BuiltInTypes.Any],
Review Comment:
@danielzhe Why changing to `Any`? Shouldn't this be `YearsAndMonthsDuration`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
