Copilot commented on code in PR #3201:
URL:
https://github.com/apache/incubator-kie-optaplanner/pull/3201#discussion_r2798296971
##########
build/optaplanner-build-parent/pom.xml:
##########
@@ -46,20 +46,20 @@
<version.org.apache.logging.log4j>2.22.1</version.org.apache.logging.log4j>
<version.com.thoughtworks.xstream>1.4.21</version.com.thoughtworks.xstream>
<version.io.quarkiverse.operatorsdk>6.6.7</version.io.quarkiverse.operatorsdk>
- <version.io.quarkus>3.20.3</version.io.quarkus>
- <version.io.netty>4.1.127.Final</version.io.netty>
+ <version.io.quarkus>3.27.2</version.io.quarkus>
+ <version.io.netty>4.1.130.Final</version.io.netty>
Review Comment:
`version.io.netty` is defined/updated here but it is not referenced anywhere
else in the repository (no `${version.io.netty}` usages). As a result, this
Netty version bump has no effect on the actual resolved Netty artifacts. Either
remove this unused property, or wire it into dependency/plugin management where
Netty is overridden so the upgrade is effective.
```suggestion
```
##########
build/optaplanner-build-parent/pom.xml:
##########
@@ -69,7 +69,7 @@
<version.asciidoctor.plugin>2.2.3</version.asciidoctor.plugin>
<version.assembly.plugin>3.4.2</version.assembly.plugin>
- <version.compiler.plugin>3.8.1</version.compiler.plugin>
+ <version.compiler.plugin>3.13.0</version.compiler.plugin>
Review Comment:
`version.compiler.plugin` is updated but appears to be unused (there is no
`${version.compiler.plugin}` reference and the `maven-compiler-plugin`
declaration in this POM has no `<version>`). If the intent is to manage the
compiler plugin version, reference this property from the
`maven-compiler-plugin` entry in pluginManagement; otherwise drop the property
to avoid confusion.
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
