Copilot commented on code in PR #6591:
URL:
https://github.com/apache/incubator-kie-drools/pull/6591#discussion_r2831648685
##########
drools-drlonyaml-parent/drools-drlonyaml-model/pom.xml:
##########
@@ -86,6 +86,23 @@
<artifactId>drools-drlonyaml-schemagen</artifactId>
<version>${project.version}</version>
</dependency>
+ <!-- Pin Jackson to match project version; victools 4.37.0
brings 2.17.2
+ which conflicts with jackson-databind 2.19.2 in exec:java
classpath -->
+ <dependency>
+ <groupId>com.fasterxml.jackson.core</groupId>
+ <artifactId>jackson-annotations</artifactId>
+
<version>${version.com.fasterxml.jackson.annotations}</version>
Review Comment:
The jackson-annotations dependency uses the version property
`version.com.fasterxml.jackson.annotations`, which is inconsistent with the
parent POM convention. In build-parent/pom.xml line 286, jackson-annotations
uses `version.com.fasterxml.jackson`. While both properties currently resolve
to 2.19.2, this inconsistency could lead to confusion and potential version
mismatches in the future. Consider using `version.com.fasterxml.jackson`
instead to align with the parent POM convention.
```suggestion
<version>${version.com.fasterxml.jackson}</version>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
