thiagoelg opened a new pull request, #3490: URL: https://github.com/apache/incubator-kie-tools/pull/3490
Fixes https://github.com/apache/incubator-kie-tools/issues/3482 When we set the flag `--if-present`, pnpm converts it to an environment variable `npm_config_if_present=true`. This env var is passed down to all subshells created by build scripts. So when it's time to execute something like this on a Makefile: ``` VERSION ?= $(shell pnpm build-env sonataFlowOperator.version) ``` the flag is still true, and pnpm won't execute the build-env command because it's not declared in the `scripts` list of the package.json. Usually, when pnpm can't find a script in the package.json it falls back to workspace or global scripts/bins, but it skips it when this flag is true. This PR fixes this issue by calling `pnpm exec build-env` instead of `pnpm build-env`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
