oEscal commented on code in PR #3939:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/3939#discussion_r2946274356
##########
quarkus/addons/knative/serving/deployment/src/main/java/org/kie/kogito/addons/quarkus/knative/serving/deployment/customfunctions/KnativeTypeHandler.java:
##########
@@ -107,6 +108,7 @@ private static List<String> getPayloadFields(FunctionRef
functionRef) {
context.getContext(), String.class,
DEFAULT_REQUEST_TIMEOUT_VALUE);
return node.workParameter(RestWorkItemHandler.BODY_BUILDER, new
ParamsRestBodyBuilderSupplier())
+ .workParameter(RestWorkItemHandler.RESULT_HANDLER, new
JsonNodeResultHandlerSupplier())
Review Comment:
I think this was a leftover from the previous implementation where I was not
considering the $WORKFLOW variable yet. However, this should be added to the
Knative custom function to give control to the developer over the status code,
message, and headers. What do you think? Do I create another issue/PR for that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
