yesamer commented on code in PR #2210:
URL:
https://github.com/apache/incubator-kie-kogito-examples/pull/2210#discussion_r3232855563
##########
gradle-examples/kogito-springboot-gradle-examples/dmn-springboot-gradle/build.gradle:
##########
@@ -33,6 +33,10 @@ repositories {
mavenLocal()
}
+// Pin Groovy 4 to match the Maven side: RestAssured 5.5.6 is compiled against
Groovy 4 and trips
+// a NullPointerException under Groovy 5. TODO drop when RestAssured ships a
Groovy 5 release.
+ext['groovy.version'] = '4.0.29'
Review Comment:
@nrknithin I read the reason for this change in the description, but it’s
not clear to me why it wasn’t previously needed with SB3.
##########
kogito-springboot-examples/onboarding-springboot/src/main/java/org/kie/kogito/examples/JacksonHttpMessageConverterConfig.java:
##########
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.kie.kogito.examples;
+
+import
org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean;
+import org.springframework.context.annotation.Bean;
+import org.springframework.context.annotation.Configuration;
+import org.springframework.http.MediaType;
+import
org.springframework.http.converter.json.MappingJackson2HttpMessageConverter;
+
+import com.fasterxml.jackson.databind.ObjectMapper;
+
+// Register a Jackson 2 HTTP converter for this module: it has no rule units,
so the
+// codegen-generated RestObjectMapper that normally provides one is not
produced here.
+// canWrite refuses String so DMN controllers' pre-serialized JSON passes
through StringHttpMessageConverter.
+// TODO drop in lock-step with the Jackson 3 migration.
Review Comment:
@nrknithin Please add this in the same ticket I mentioned here
https://github.com/apache/incubator-kie-drools/issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
