yesamer commented on code in PR #6633:
URL:
https://github.com/apache/incubator-kie-drools/pull/6633#discussion_r3232992645
##########
bom/drools-bom/pom.xml:
##########
@@ -1045,11 +1045,12 @@
<artifactId>default-kiesession</artifactId>
<version>${project.version}</version>
</dependency>
- <dependency>
+ <!-- NOT SURE ABOUT THIS ONE!!!! -->
+ <!--<dependency>
<groupId>org.drools</groupId>
<artifactId>cdi-example</artifactId>
<version>${project.version}</version>
- </dependency>
+ </dependency>-->
Review Comment:
@gitgabrio Can we remove that?
##########
drools-test-coverage/drools-test-coverage-jars/drools-test-coverage-jars-with-invoker/pom.xml:
##########
@@ -69,6 +60,7 @@
<artifactId>maven-invoker-plugin</artifactId>
<configuration>
<cloneProjectsTo>${project.build.directory}/it</cloneProjectsTo>
+ <logDirectory>${path.to.buildlog.directory}</logDirectory>
Review Comment:
@gitgabrio Same, I guess it is related?
##########
kie-maven-plugin/src/it/kie-maven-plugin-test-kjar-3/src/test/java-filtered/org/kie/maven/plugin/ittests/AdditionalPropertiesIntegrationTestIT.java:
##########
@@ -29,13 +29,15 @@
public class AdditionalPropertiesIntegrationTestIT {
+ private final String buildLogsDir = "${buildlog.directory}";
@Test
public void testAdditionalPropertiesCorrectlySet() throws Exception {
// additional properties are logged during debug (-X) build
// following string is created directly inside the KIE Maven plugin
execution (the property names and values
// are logged multiple by maven itself as well, so we should check
directly against that string)
final URL targetLocation =
AdditionalPropertiesIntegrationTestIT.class.getProtectionDomain().getCodeSource().getLocation();
- final File basedir = new
File(targetLocation.getFile().replace("/target/test-classes/", ""));
+ System.out.println("buildLogsDir: " + buildLogsDir);
Review Comment:
@gitgabrio Is this System.out.println still needed?
##########
.github/workflows/pr-downstream.yml:
##########
@@ -68,6 +68,7 @@ jobs:
name: ${{ matrix.job_name }} (${{ matrix.os }} / Java-${{
matrix.java-version }} / Maven-${{ matrix.maven-version }})
env:
DEPENDENCY_TREE_FILE: 'mvn_dependency_tree_${{ matrix.job_name }}_${{
matrix.os }}.txt'
+ BUILD_LOGS_DIR: 'build_logs'
Review Comment:
@gitgabrio Why this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
