gitgabrio commented on code in PR #4241:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4241#discussion_r3242142877
##########
quarkus/bom/pom.xml:
##########
@@ -1,60 +1,66 @@
<?xml version="1.0" encoding="UTF-8"?>
<!--
-
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
-
http://www.apache.org/licenses/LICENSE-2.0
-
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-
-->
-<project xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xmlns="http://maven.apache.org/POM/4.0.0";
- xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/maven-v4_0_0.xsd";>
-
+<project xmlns="http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/maven-v4_0_0.xsd";>
<modelVersion>4.0.0</modelVersion>
-
<parent>
<groupId>org.kie.kogito</groupId>
- <artifactId>quarkus</artifactId>
+ <artifactId>kogito-build-no-bom-parent</artifactId>
<version>999-SNAPSHOT</version>
+
<relativePath>../../kogito-build/kogito-build-no-bom-parent/pom.xml</relativePath>
</parent>
-
<artifactId>kogito-quarkus-bom</artifactId>
<packaging>pom</packaging>
-
<name>Kogito :: Quarkus :: BOM</name>
<description>Internal BOM descriptor for Kogito modules targeting Quarkus
use-cases. Specific dependencies targeting the Quarkus platform must be added
here.</description>
-
<properties>
- <!-- Keep it aligned with
https://github.com/quarkusio/quarkus/blob/3.27.3/pom.xml#L72 -->
-
<version.io.fabric8.kubernetes-client>7.3.1</version.io.fabric8.kubernetes-client>
+ <!-- Used to define which poms are allowed to have dependencyManagement
sections. This is to enforce the convention that only the root pom should have
dependencyManagement, and all other poms should inherit from it. -->
+ <allowedPomsList>org.kie.kogito:kogito-quarkus-bom</allowedPomsList>
+
<quarkus.logging.manager>org.jboss.logmanager.LogManager</quarkus.logging.manager>
+ <version.io.quarkus>3.27.3</version.io.quarkus>
+
<version.io.quarkus.quarkus-test>${version.io.quarkus}</version.io.quarkus.quarkus-test>
+
<version.io.quarkiverse.jackson-jq>2.4.0</version.io.quarkiverse.jackson-jq>
+
<version.io.quarkiverse.openapi.generator>2.11.0-lts</version.io.quarkiverse.openapi.generator>
+ <version.io.quarkiverse.asyncapi>1.0.5</version.io.quarkiverse.asyncapi>
+
<version.io.quarkiverse.reactivemessaging.http>2.5.0-lts</version.io.quarkiverse.reactivemessaging.http>
+
<version.io.quarkiverse.embedded.postgresql>0.8.0</version.io.quarkiverse.embedded.postgresql>
+ <version.io.quarkus.camel>3.27.3</version.io.quarkus.camel>
Review Comment:
TBH I'm not 100% sure.
The camel quarkus artifacts comes from a different groupId
```xml
<dependency>
<groupId>org.apache.camel.quarkus</groupId>
<artifactId>camel-quarkus-direct</artifactId>
<version>${version.io.quarkus.camel}</version>
</dependency>
```
so I think there is not an absolute guarantee that they will always been the
same: am I clear ? Does this make sense ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
