yesamer commented on code in PR #2317:
URL:
https://github.com/apache/incubator-kie-kogito-apps/pull/2317#discussion_r3261469271
##########
trusty/trusty-storage/trusty-storage-infinispan/pom.xml:
##########
Review Comment:
@gitgabrio I'm aware there is an ongoing initiative to remove infinispan
support, is this module removal related to that?
##########
apps-integration-tests/integration-tests-trusty-service/integration-tests-trusty-service-common/src/main/java/org/kie/kogito/it/trusty/AbstractTrustyExplainabilityEnd2EndIT.java:
##########
Review Comment:
@gitgabrio Was the integration-tests-trusty-service-common intentionally
removed? Why?
##########
trusty/trusty-service/trusty-service-common/src/test/java/org/kie/kogito/trusty/service/common/KeycloakTrustyServiceIT.java:
##########
@@ -55,15 +55,16 @@ class KeycloakTrustyServiceIT {
@InjectMock
TrustyService trustyService;
- @Test
+ /* @Test */
void shouldReturnUnauthorized() {
given().get(TRUSTY_ENDPOINT)
.then().statusCode(HttpStatus.SC_UNAUTHORIZED);
}
- @Test
+ /* @Test */
Review Comment:
@gitgabrio As you disabled the entire Class, I guess you can remove the
comment.
##########
trusty/trusty-service/trusty-service-common/src/test/java/org/kie/kogito/trusty/service/common/KeycloakTrustyServiceIT.java:
##########
@@ -55,15 +55,16 @@ class KeycloakTrustyServiceIT {
@InjectMock
TrustyService trustyService;
- @Test
+ /* @Test */
Review Comment:
@gitgabrio As you disabled the entire Class, I guess you can remove the
comment.
##########
trusty/trusty-service/trusty-service-postgresql/pom.xml:
##########
@@ -88,38 +91,4 @@
<scope>test</scope>
</dependency>
</dependencies>
-
- <build>
- <plugins>
- <plugin>
- <groupId>io.quarkus</groupId>
- <artifactId>quarkus-maven-plugin</artifactId>
Review Comment:
@gitgabrio Can you please clarify the trusty-module module management? It
previously was a quarkus app and now in no longer that?
##########
trusty/trusty-service/trusty-service-common/src/test/java/org/kie/kogito/trusty/service/common/KeycloakTrustyServiceIT.java:
##########
@@ -55,15 +55,16 @@ class KeycloakTrustyServiceIT {
@InjectMock
TrustyService trustyService;
- @Test
+ /* @Test */
void shouldReturnUnauthorized() {
given().get(TRUSTY_ENDPOINT)
.then().statusCode(HttpStatus.SC_UNAUTHORIZED);
}
- @Test
+ /* @Test */
void shouldReturnOkWhenValidUser() {
- when(trustyService.getExecutionHeaders(any(OffsetDateTime.class),
any(OffsetDateTime.class), anyInt(), anyInt(), anyString())).thenReturn(new
MatchedExecutionHeaders(new ArrayList<>(), 0));
+ when(trustyService.getExecutionHeaders(any(OffsetDateTime.class),
any(OffsetDateTime.class), anyInt(),
+ anyInt(), anyString())).thenReturn(new
MatchedExecutionHeaders(new ArrayList<>(), 0));
Review Comment:
I guess this line change is useless
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
