kbowers-ibm commented on PR #3555: URL: https://github.com/apache/incubator-kie-tools/pull/3555#issuecomment-4506670644
Hi @jomarko Thank you very much for the review! [bug] BPMN Editor: Correlation Key and Subscription not cleaned up after deletion > It seems new editor does not load that file in a way, that would display all data. For example properties panel does not show message for message events. Yeah that's a problem we've had elsewhere, I'll look into the exact fields that aren't displaying and create a separate ticket for it, thank you! > It is using correlations. When I delete all correlation stuff, there remains collaboration 🟠That's intentional, the old bpmn editor always has a collaboration+participant so I wanted to keep the functionality the same. [bug] BPMN Editor: Message Start Event-itemDefinition Not Assigning Value to structureRef > is it expected new editor set all message structure ref to Object? 🟠Yes we decided to create a default value of Object for all itemDefinitions, unless specified otherwise. And we've also created a generic itemDefinition that relates to all messages, which has the value: ` <itemDefinition id="__messageItemDefinition" structureRef="Object" /> `That way we don't clutter the xml with too many itemDefinitions, and only update them when the message needs to be linked to a specific itemDefinition -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
