Re: [PR] kie-issues#2304: BPMN Editor: Usertask On-entry script scriptFormat not persisted [incubator-kie-tools]

[via GitHub]

rajalakshmys-27 commented on PR #3578:
URL: 
https://github.com/apache/incubator-kie-tools/pull/3578#issuecomment-4507143424

   > Thank you for the PR. I have this uncertainties about it.
   > 
   > ### 01 BPMN Elements with a script
   > Does this PR handle all situations, when user should set a script? For 
example there is also a script when we have an edge form the gateway.
   > 
   > <img alt="Image" width="1586" height="677" 
src="https://private-user-images.githubusercontent.com/8044780/593901766-d42ba135-0062-4b35-9e11-5853a2d97ce3.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NzkzNTQ0MjQsIm5iZiI6MTc3OTM1NDEyNCwicGF0aCI6Ii84MDQ0NzgwLzU5MzkwMTc2Ni1kNDJiYTEzNS0wMDYyLTRiMzUtOWUxMS01ODUzYTJkOTdjZTMucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI2MDUyMSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNjA1MjFUMDkwMjA0WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZmFmNWNkOWZiMjBjY2QzZWVmZTA4ZmNkNDVkMDI0NDU0NDQ2MGY5YTViZmY4OGEzNmQ0NmEwOTYxYmNjNTQwMCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmcmVzcG9uc2UtY29udGVudC10eXBlPWltYWdlJTJGcG5nIn0.kRTiInQ3Fssqs6mEEEg1uRKL-xKgBzzAuozFOxb4i4Y";>
   > ### 02 Script Change
   > The added code brings an impression, many script languages can be used. 
However looking on the properties panel, it seems there is only indicator of 
the script language, shouldn't be there an option to change the script language 
if we add similar PR?
   > 
   > ### 03 Script Support
   > This is related to **02**. Are we sure that using all mentioned scripts
   > 
   > * Java
   > * Mvel
   > * Drools
   > * Feel
   > 
   > are supported everywhere:
   > 
   > * script task
   > * entry / exit scripts
   > * edges from gateways
   > * conditional events
   > 
   > in other words, will run such bpmn definitions fine in our kogito-examples?
   
   
   **PR Intent:** Fix the bug where `scriptFormat` was left empty in BPMN 
script tasks and on-entry/on-exit scripts.  
   This ensures generated BPMN XML is valid and executable.
   
   
   ### Question 01: BPMN Elements with a Script  
   **Does this PR handle all situations when a user should set a script?**
   Answer : No, that is another issue.
   - Handled: Script Tasks, On-Entry Scripts, On-Exit Scripts -> all now set 
@_scriptFormat properly.
   - Not handled: Gateway edge conditions (sequence flows). These use 
@_language, not @_scriptFormat.
   So,
   - Script elements and expression elements rely on different attributes 
(scriptFormat vs language).
   - The missing @_language on gateway edge conditions is outside the scope of 
this PR and should be tracked separately.
   
   ### Question 02: Script Change  
   **Should there be an option to change the script language?**
   Answer: No, that is another issue that can be handled as a separate 
enhancement.
   - The current UI only shows Java as the default.  
   - This PR fixes the bug by ensuring (Java) scripts have a valid URI.  
   - Supporting multi-language selection (Java, MVEL, Drools, FEEL) would 
require additional change
   
   ### Question 03: Script Support  
   **Are all mentioned scripts (Java, MVEL, Drools, FEEL) supported 
everywhere?**
   Answer: Unclear, needs testing. This PR correctly implements Java, which is 
the only language currently used in script tasks.
   
   | Context | Java | MVEL | Drools | FEEL | Attribute Used |
   | --- | --- | --- | --- | --- | --- |
   | Script Tasks | Yes | No | No | No | `@_scriptFormat` |
   | Entry/Exit Scripts | Yes | No | No | No | `@_scriptFormat` |
   | Gateway Edges | UI shows options, but `@_language` missing | | | | 
`@_language` |
   | Conditional Events | Drools used | | | | `@_language` |
   | Multi-instance Completion | MVEL used | | | | `@_language` |
   
   We can Open separate **issues** to:  
     - Add `@_language` to expression elements.  
     - Align UI options with real supported languages.
     - Test actual language support in `kogito-examples`.  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org
For additional commands, e-mail: commits-h...@kie.apache.org