thiagoelg commented on code in PR #3538:
URL:
https://github.com/apache/incubator-kie-tools/pull/3538#discussion_r3281913026
##########
examples/process-accelerator/pom.xml:
##########
@@ -25,9 +25,9 @@
<modelVersion>4.0.0</modelVersion>
<parent>
<groupId>org.kie</groupId>
- <artifactId>kie-tools-maven-base</artifactId>
+ <artifactId>kie-tools-quarkus-bom</artifactId>
Review Comment:
I don't think we need the `maven` prefix in the package name. Having it
implies that there's also a non-Maven BOM.
To me, naming the artifacts `kie-tools-quarkus-bom` and
`kie-tools-spring-boot-bom` works, and then naming the packages `quarkus-bom`
and `spring-boot-bom`, since `kie-tools` is already implied.
I'm not against having the folder named the same as the artifactId, but
that's not the standard in the repository right now, and it would look out of
place. In the future, we can investigate whether it makes sense to do so and
then update all packages that apply.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
