GopikaReghunath commented on code in PR #4273:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4273#discussion_r3310738015
##########
addons/common/jbpm-usertask-storage-jpa/src/main/java/org/jbpm/usertask/jpa/repository/UserTaskInstanceRepository.java:
##########
@@ -42,6 +52,73 @@ public List<UserTaskInstanceEntity>
findByIdentity(IdentityProvider identityProv
return query.getResultList();
}
+ public List<UserTaskInstanceEntity>
findByIdentityAndFilter(IdentityProvider identityProvider, UserTaskFilter
filter) {
+ // If no filter, use the optimized named query
+ if (filter == null) {
+ return findByIdentity(identityProvider);
+ }
+
+ // Build single query combining identity and filter predicates using
Criteria API
+ CriteriaBuilder cb = getEntityManager().getCriteriaBuilder();
+ CriteriaQuery<UserTaskInstanceEntity> cq =
cb.createQuery(UserTaskInstanceEntity.class);
Review Comment:
comment addressed
##########
addons/common/jbpm-usertask-storage-jpa/src/main/java/org/jbpm/usertask/jpa/repository/UserTaskInstanceRepository.java:
##########
@@ -42,6 +52,73 @@ public List<UserTaskInstanceEntity>
findByIdentity(IdentityProvider identityProv
return query.getResultList();
}
+ public List<UserTaskInstanceEntity>
findByIdentityAndFilter(IdentityProvider identityProvider, UserTaskFilter
filter) {
+ // If no filter, use the optimized named query
+ if (filter == null) {
+ return findByIdentity(identityProvider);
Review Comment:
comment addressed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
