ljmotta commented on code in PR #3559:
URL:
https://github.com/apache/incubator-kie-tools/pull/3559#discussion_r3343795158
##########
packages/pmml-editor/src/editor/PMMLEditor.tsx:
##########
@@ -121,7 +122,10 @@ export class PMMLEditor extends React.Component<Props,
State> {
}
public componentDidMount(): void {
- this.props.ready();
+ // Use flushSync to ensure the editor is fully mounted before signaling
ready
+ flushSync(() => {
+ this.props.ready();
+ });
Review Comment:
This flushSync is required so we are sure the editor is ready before
redering it. We had a problem with PMML Editor on `online-editor` where PMML
would be never "ready".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
