This is an automated email from the ASF dual-hosted git repository.
Rikkola pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-kie-drools.git
The following commit(s) were added to refs/heads/main by this push:
new b6fc3f0050b [incubator-kie-issues-2344] Fix NPE evaluating after()
under an OR-of-negated-join (#6760)
b6fc3f0050b is described below
commit b6fc3f0050bd1e818392bef0597ac488c05ffc19
Author: Toni Rikkola <[email protected]>
AuthorDate: Thu Jun 18 16:02:03 2026 +0300
[incubator-kie-issues-2344] Fix NPE evaluating after() under an
OR-of-negated-join (#6760)
An executable-model rule with a top-level or(...) whose branch is a negated
join (and(not(x), y)) and a later pattern carrying a temporal after()
constraint
threw an NPE during evaluation:
ConstraintEvaluationException: Error evaluating constraint '' ... in more
rules
Caused by NullPointerException:
Cannot invoke "TupleImpl.getIndex()" because "entry" is null
When the LHS OR is expanded into per-branch subrules, the shared trailing
elements are cloned and each clone's declarations are rebound to its own
subrule's patterns (replaceDeclaration reassigns an array slot).
TemporalConstraintEvaluator.clone() shared the declarations array by
reference,
so one subrule's rebinding clobbered the others, leaving a temporal beta
pointing at a sibling branch's pattern tuple index -- an index absent from
this
branch's shorter tuple, causing the NPE in TupleImpl.get. (DRL is
unaffected:
its parser expands disjunctions before compilation.)
Copy the array (shallow) so each clone rebinds independently. A deep clone
via
getClonedDeclarations() regresses the NamedConsequence path, whose clones
are
not re-bound and rely on the original Declaration objects.
Adds OrNegatedJoinAfterReproTest (minimal repro + two controls). Verified:
model-compiler suite green; CEP/subnetwork/accumulate blast-radius 519/0/0.
Closes apache/incubator-kie-issues#2344
https://github.com/apache/incubator-kie-issues/issues/2344
Co-Assisted-By: Claude <[email protected]>
---
.../constraints/TemporalConstraintEvaluator.java | 4 +-
.../modelcompiler/OrNegatedJoinAfterReproTest.java | 143 +++++++++++++++++++++
2 files changed, 146 insertions(+), 1 deletion(-)
diff --git
a/drools-model/drools-model-compiler/src/main/java/org/drools/modelcompiler/constraints/TemporalConstraintEvaluator.java
b/drools-model/drools-model-compiler/src/main/java/org/drools/modelcompiler/constraints/TemporalConstraintEvaluator.java
index 23ab2133e3b..6913384f6e4 100644
---
a/drools-model/drools-model-compiler/src/main/java/org/drools/modelcompiler/constraints/TemporalConstraintEvaluator.java
+++
b/drools-model/drools-model-compiler/src/main/java/org/drools/modelcompiler/constraints/TemporalConstraintEvaluator.java
@@ -31,6 +31,8 @@ import org.drools.model.functions.Function1;
import org.drools.model.functions.temporal.TemporalPredicate;
import org.kie.api.runtime.rule.FactHandle;
+import java.util.Arrays;
+
import static org.drools.base.util.TimeIntervalParser.getTimestampFromDate;
public class TemporalConstraintEvaluator extends ConstraintEvaluator {
@@ -110,7 +112,7 @@ public class TemporalConstraintEvaluator extends
ConstraintEvaluator {
@Override
public TemporalConstraintEvaluator clone() {
- return new TemporalConstraintEvaluator( getDeclarations(),
getPattern(), constraint );
+ return new TemporalConstraintEvaluator( Arrays.copyOf( declarations,
declarations.length ), getPattern(), constraint );
}
@Override
diff --git
a/drools-model/drools-model-compiler/src/test/java/org/drools/modelcompiler/OrNegatedJoinAfterReproTest.java
b/drools-model/drools-model-compiler/src/test/java/org/drools/modelcompiler/OrNegatedJoinAfterReproTest.java
new file mode 100644
index 00000000000..c114d50bb9a
--- /dev/null
+++
b/drools-model/drools-model-compiler/src/test/java/org/drools/modelcompiler/OrNegatedJoinAfterReproTest.java
@@ -0,0 +1,143 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.drools.modelcompiler;
+
+import org.drools.model.Model;
+import org.drools.model.Rule;
+import org.drools.model.Variable;
+import org.drools.model.impl.ModelImpl;
+import org.drools.modelcompiler.KieBaseBuilder;
+import org.junit.jupiter.api.Test;
+import org.kie.api.KieBase;
+import org.kie.api.KieServices;
+import org.kie.api.conf.EventProcessingOption;
+import org.kie.api.definition.type.Role;
+import org.kie.api.runtime.KieSession;
+import org.kie.api.runtime.KieSessionConfiguration;
+import org.kie.api.runtime.conf.ClockTypeOption;
+import org.kie.api.time.SessionPseudoClock;
+
+import java.util.List;
+import java.util.concurrent.TimeUnit;
+
+import static org.drools.model.DSL.after;
+import static org.drools.model.DSL.declarationOf;
+import static org.drools.model.DSL.execute;
+import static org.drools.model.DSL.not;
+import static org.drools.model.PatternDSL.and;
+import static org.drools.model.PatternDSL.or;
+import static org.drools.model.PatternDSL.pattern;
+import static org.drools.model.PatternDSL.rule;
+
+public class OrNegatedJoinAfterReproTest {
+
+ @Role(Role.Type.EVENT) public static class EvC { public int id; public
EvC(int id){this.id=id;} public int getId(){return id;} }
+ @Role(Role.Type.EVENT) public static class EvD { public int id; public
EvD(int id){this.id=id;} public int getId(){return id;} }
+ @Role(Role.Type.EVENT) public static class EvE { public int id; public
EvE(int id){this.id=id;} public int getId(){return id;} }
+
+ private static void buildAndReplay(Rule r) {
+ Model model = new ModelImpl().addRule(r);
+ KieBase kb = KieBaseBuilder.createKieBaseFromModel(model,
EventProcessingOption.STREAM);
+ KieSessionConfiguration conf =
KieServices.get().newKieSessionConfiguration();
+ conf.setOption(ClockTypeOption.PSEUDO);
+ KieSession ks = kb.newKieSession(conf, null);
+ SessionPseudoClock clock = ks.getSessionClock();
+ List<Object> events = List.of(
+ new EvC(1), new EvD(1), new EvE(1),
+ new EvC(2), new EvD(2), new EvE(2));
+ try {
+ for (Object e : events) {
+ clock.advanceTime(1, TimeUnit.MILLISECONDS);
+ ks.insert(e);
+ ks.fireAllRules();
+ }
+ ks.fireAllRules();
+ } finally {
+ ks.dispose();
+ }
+ }
+
+ @Test
+ public void orWithNegatedJoinBranchPlusDownstreamAfterRunsWithoutNPE() {
+ Variable<EvE> e1 = declarationOf(EvE.class);
+ Variable<EvE> e2 = declarationOf(EvE.class);
+ Variable<EvC> c = declarationOf(EvC.class);
+ Variable<EvE> et = declarationOf(EvE.class);
+ Variable<EvD> d = declarationOf(EvD.class);
+
+ Rule r = rule("min-or-negjoin-after").build(
+ or(
+ pattern(e1).expr("e1", v -> true),
+ and(
+ not(pattern(e2).expr("e2", v -> true)),
+ pattern(c).expr("c", v -> true)
+ )
+ ),
+ pattern(et).expr("et", v -> true),
+ pattern(d).expr("d", v -> true).expr("d_after_et", et, after()),
+ execute(() -> {})
+ );
+
+ buildAndReplay(r); // must not throw
+ }
+
+ @Test
+ public void controlDropAfterRunsWithoutNPE() {
+ Variable<EvE> e1 = declarationOf(EvE.class);
+ Variable<EvE> e2 = declarationOf(EvE.class);
+ Variable<EvC> c = declarationOf(EvC.class);
+ Variable<EvE> et = declarationOf(EvE.class);
+ Variable<EvD> d = declarationOf(EvD.class);
+
+ Rule r = rule("ctrl-no-after").build(
+ or(
+ pattern(e1).expr("e1", v -> true),
+ and(
+ not(pattern(e2).expr("e2", v -> true)),
+ pattern(c).expr("c", v -> true)
+ )
+ ),
+ pattern(et).expr("et", v -> true),
+ pattern(d).expr("d", v -> true),
+ execute(() -> {})
+ );
+
+ buildAndReplay(r);
+ }
+
+ @Test
+ public void controlDropOrRunsWithoutNPE() {
+ Variable<EvE> e2 = declarationOf(EvE.class);
+ Variable<EvC> c = declarationOf(EvC.class);
+ Variable<EvE> et = declarationOf(EvE.class);
+ Variable<EvD> d = declarationOf(EvD.class);
+
+ Rule r = rule("ctrl-no-or").build(
+ and(
+ not(pattern(e2).expr("e2", v -> true)),
+ pattern(c).expr("c", v -> true)
+ ),
+ pattern(et).expr("et", v -> true),
+ pattern(d).expr("d", v -> true).expr("d_after_et", et, after()),
+ execute(() -> {})
+ );
+
+ buildAndReplay(r);
+ }
+}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
